Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 403593003: Trace RenderViewImpl::OnResize (Closed)

Created:
6 years, 5 months ago by Yufeng Shen (Slow to review)
Modified:
6 years, 5 months ago
Reviewers:
jamesr
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, jdduke (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Trace RenderViewImpl::OnResize The trace comes handy when unexpected resize message triggers a main frame. BUG=392652 TEST=do a trace for scrolling a page on clank during which the top control becomes hidden, and found that at the end of scroll there is a RenderViewImpl::OnResize trace event. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yufeng Shen (Slow to review)
6 years, 5 months ago (2014-07-17 19:25:39 UTC) #1
jamesr
lgtm
6 years, 5 months ago (2014-07-17 20:05:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/403593003/1
6 years, 5 months ago (2014-07-17 20:12:36 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 00:27:58 UTC) #4
Message was sent while issue was closed.
Change committed as 283947

Powered by Google App Engine
This is Rietveld 408576698