Improve messaging for shared modules on chrome://extensions

chrome/browser/resources/extensions/extension_list.js

Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index b3a8f29cc23c10157479827b2551a56ffac472db..050466574d5746cdeb94dbf8eacbb1c25a9b4f53 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -85,7 +85,7 @@ cr.define('options', function() {
       if (!extension.enabled || extension.terminated)
         node.classList.add('inactive-extension');
 
-      if (extension.managedInstall) {
+      if (extension.managedInstall || extension.managedSharedModule) {
         node.classList.add('may-not-modify');
         node.classList.add('may-not-remove');
       } else if (extension.suspiciousInstall || extension.corruptInstall) {
@@ -238,7 +238,8 @@ cr.define('options', function() {
         enable.hidden = false;
         var managedOrHosedExtension = extension.managedInstall ||
                                       extension.suspiciousInstall ||
-                                      extension.corruptInstall;
+                                      extension.corruptInstall ||
+                                      extension.managedSharedModule;
         enable.querySelector('input').disabled = managedOrHosedExtension;
 
         if (!managedOrHosedExtension) {
@@ -312,6 +313,17 @@ cr.define('options', function() {
         }
       }
 
+      if (extension.is_shared_module && extension.dependents.length > 0) {

[not at google - send to devlin, 2014/07/17 20:44:52]

seems like this should be isSharedModule not is_shared_module

and similar question re the extension.dependents.length check. it seems very
similar to this "managed" concept but they're treated differently? like you
shouldn't be able to uninstall a shared module that has any dependent
extensions.

[elijahtaylor1, 2014/07/17 21:45:30]

Hmm, this makes a lot of sense.  We should never have a shared module in the
list that doesn't have dependent extensions if it was CWS installed (because it
will be auto uninstalled), and we probably want to avoid letting even developers
who side-loaded or unpacked loaded an extension if another extension depends on
it.

+        var sharedModule = node.querySelector('.shared-module-message');
+        sharedModule.hidden = false;
+        var sharedModuleList = sharedModule.querySelector('ul');
+        extension.dependents.forEach(function(id) {
+          var li = document.createElement('li');
+          li.innerText = id;
+          sharedModuleList.appendChild(li);
+        });
+      }
+
       // Then active views.
       if (extension.views.length > 0) {
         var activeViews = node.querySelector('.active-views');