Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: extensions/common/extension.cc

Issue 403593002: Improve messaging for shared modules on chrome://extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/extension.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/extension.cc
diff --git a/extensions/common/extension.cc b/extensions/common/extension.cc
index f19ef51f862944af5e7576eeec53cd8c57c0b487..89d50f0e098e248c56fbd382acb83b41f45f72b4 100644
--- a/extensions/common/extension.cc
+++ b/extensions/common/extension.cc
@@ -411,11 +411,11 @@ void Extension::AddInstallWarnings(
}
bool Extension::is_app() const {
- return manifest_->is_app();
+ return manifest()->is_app();
}
bool Extension::is_platform_app() const {
- return manifest_->is_platform_app();
+ return manifest()->is_platform_app();
}
bool Extension::is_hosted_app() const {
@@ -430,6 +430,14 @@ bool Extension::is_extension() const {
return manifest()->is_extension();
}
+bool Extension::is_shared_module() const {
+ return manifest()->is_shared_module();
+}
+
+bool Extension::is_theme() const {
+ return manifest()->is_theme();
+}
+
bool Extension::can_be_incognito_enabled() const {
// Only component platform apps are supported in incognito.
return !is_platform_app() || location() == Manifest::COMPONENT;
@@ -443,10 +451,6 @@ void Extension::AddWebExtentPattern(const URLPattern& pattern) {
extent_.AddPattern(pattern);
}
-bool Extension::is_theme() const {
- return manifest()->is_theme();
-}
-
// static
bool Extension::InitExtensionID(extensions::Manifest* manifest,
const base::FilePath& path,
« no previous file with comments | « extensions/common/extension.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698