Improve messaging for shared modules on chrome://extensions

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js"></include>
 
 cr.define('options', function() {
   'use strict';
 
   /**
@@ skipping 67 matching lines @@
      */
     createNode_: function(extension) {
       var template = $('template-collection').querySelector(
           '.extension-list-item-wrapper');
       var node = template.cloneNode(true);
       node.id = extension.id;
 
       if (!extension.enabled || extension.terminated)
         node.classList.add('inactive-extension');
 
-      if (extension.managedInstall) {
+      if (extension.managedInstall || extension.managedSharedModule) {
         node.classList.add('may-not-modify');
         node.classList.add('may-not-remove');
       } else if (extension.suspiciousInstall || extension.corruptInstall) {
         node.classList.add('may-not-modify');
       }
 
       var idToHighlight = this.getIdQueryParam_();
       if (node.id == idToHighlight)
         node.classList.add('extension-highlight');
 
@@ skipping 132 matching lines @@
           launch.hidden = false;
         }
       }
 
       if (!extension.terminated) {
         // The 'Enabled' checkbox.
         var enable = node.querySelector('.enable-checkbox');
         enable.hidden = false;
         var managedOrHosedExtension = extension.managedInstall ||
                                       extension.suspiciousInstall ||
-                                      extension.corruptInstall;
+                                      extension.corruptInstall ||
+                                      extension.managedSharedModule;
         enable.querySelector('input').disabled = managedOrHosedExtension;
 
         if (!managedOrHosedExtension) {
           enable.addEventListener('click', function(e) {
             // When e.target is the label instead of the checkbox, it doesn't
             // have the checked property and the state of the checkbox is
             // left unchanged.
             var checked = e.target.checked;
             if (checked == undefined)
               checked = !e.currentTarget.querySelector('input').checked;
@@ skipping 53 matching lines @@
         if (extension.suspiciousInstall) {
           // Then the 'This isn't from the webstore, looks suspicious' message.
           node.querySelector('.suspicious-install-message').hidden = false;
         }
         if (extension.corruptInstall) {
           // Then the 'This is a corrupt extension' message.
           node.querySelector('.corrupt-install-message').hidden = false;
         }
       }
 
+      if (extension.is_shared_module && extension.dependents.length > 0) {

[not at google - send to devlin, 2014/07/17 20:44:52]

seems like this should be isSharedModule not is_shared_module

and similar question re the extension.dependents.length check. it seems very
similar to this "managed" concept but they're treated differently? like you
shouldn't be able to uninstall a shared module that has any dependent
extensions.

[elijahtaylor1, 2014/07/17 21:45:30]

Hmm, this makes a lot of sense.  We should never have a shared module in the
list that doesn't have dependent extensions if it was CWS installed (because it
will be auto uninstalled), and we probably want to avoid letting even developers
who side-loaded or unpacked loaded an extension if another extension depends on
it.

+        var sharedModule = node.querySelector('.shared-module-message');
+        sharedModule.hidden = false;
+        var sharedModuleList = sharedModule.querySelector('ul');
+        extension.dependents.forEach(function(id) {
+          var li = document.createElement('li');
+          li.innerText = id;
+          sharedModuleList.appendChild(li);
+        });
+      }
+
       // Then active views.
       if (extension.views.length > 0) {
         var activeViews = node.querySelector('.active-views');
         activeViews.hidden = false;
         var link = activeViews.querySelector('a');
 
         extension.views.forEach(function(view, i) {
           var displayName = view.generatedBackgroundPage ?
               loadTimeData.getString('backgroundPage') : view.path;
           var label = displayName +
@@ skipping 65 matching lines @@
           topScroll -= pad / 2;
         setScrollTopForDocument(document, topScroll);
       }
     },
   };
 
   return {
     ExtensionsList: ExtensionsList
   };
 });