Enable the SSSE3 compile time check on all platforms.

Enable the SSSE3 compile time check on all platforms (3rd attempt)

BUG=skia:2746
Committed: https://skia.googlesource.com/skia/+/933834851f9d48fbd85b728cc92e1f0134bfaa4e

[hal.canary, 2014-07-21 19:48:28]

https://codereview.chromium.org/403583002/diff/40001/gyp/opts.gyp
File gyp/opts.gyp (right):

https://codereview.chromium.org/403583002/diff/40001/gyp/opts.gyp#newcode241
gyp/opts.gyp:241: ],
Delete lines 241 and 242.

https://codereview.chromium.org/403583002/diff/40001/src/opts/SkBlurImage_opt...
File src/opts/SkBlurImage_opts_SSE4.cpp (right):

https://codereview.chromium.org/403583002/diff/40001/src/opts/SkBlurImage_opt...
src/opts/SkBlurImage_opts_SSE4.cpp:21: #error SK_CPU_SSE_LEVEL_SSE41
delete line 21

[djsollen, 2014-07-21 20:15:33]

we should be good to go this time around! :)

[mtklein, 2014-07-22 13:43:08]

Not going to even pretend I understand how this fixed it, but if it works, it
works!

LGTM

[djsollen, 2014-07-22 14:08:35]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2014-07-22 14:09:24]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/djsollen@google.com/403583002/60001

[commit-bot: I haz the power, 2014-07-22 14:20:23]

Change committed as 933834851f9d48fbd85b728cc92e1f0134bfaa4e

[bungeman-skia, 2014-07-23 18:27:19]

A revert of this CL has been created in
https://codereview.chromium.org/418523002/ by bungeman@google.com.

The reason for reverting is: This is blocking the roll. Chromium Windows trybots
(like win_chromium_x64_rel) are crashing in the SSSE3 code (for example
SkCanvasVideoRenderTest.CroppedFrame)..

[gw280, 2014-08-27 15:12:31]

On 2014/07/23 18:27:19, bungeman1 wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/418523002/ by mailto:bungeman@google.com.
> 
> The reason for reverting is: This is blocking the roll. Chromium Windows
trybots
> (like win_chromium_x64_rel) are crashing in the SSSE3 code (for example
> SkCanvasVideoRenderTest.CroppedFrame)..

Can this land again now that Chrome has (presumably) rolled?

[djsollen, 2014-08-27 15:40:16]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2014-08-27 15:41:18]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/djsollen@google.com/403583002/80001

[commit-bot: I haz the power, 2014-08-27 15:41:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 15:41:22]

Failed to apply patch for gyp/common_conditions.gypi:
While running git apply --index -p1;
  error: patch failed: gyp/common_conditions.gypi:646
  error: gyp/common_conditions.gypi: patch does not apply

Patch:       gyp/common_conditions.gypi
Index: gyp/common_conditions.gypi
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi
index
69f1ddbcd4fe47d50b7c4d11262743a2d670088e..abb47502b639bdbc44c1723f557e0a38800b5647
100644
--- a/gyp/common_conditions.gypi
+++ b/gyp/common_conditions.gypi
@@ -646,6 +646,11 @@
           '-fuse-ld=gold',
         ],
         'conditions': [
+          [ 'skia_arch_type == "x86"', {
+            'cflags': [
+              '-mssse3',
+            ],
+          }],
           [ 'skia_android_framework', {
             'libraries!': [
               '-lstdc++',

[djsollen, 2014-08-27 15:45:41]

forgot that I already landed this in https://codereview.chromium.org/414033002