Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 403573004: Tweak expectations for VideoRendererImplTest.StartPlayingFrom_LowDelay. (Closed)

Created:
6 years, 5 months ago by scherkus (not reviewing)
Modified:
6 years, 5 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Tweak expectations for VideoRendererImplTest.StartPlayingFrom_LowDelay. Until we get rid of the internal thread, the buffering events will fire non-deterministically. For example, under valgrind it's possible for them to never fire. BUG=144683 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283998

Patch Set 1 #

Total comments: 2

Patch Set 2 : AnyNumber() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M media/filters/video_renderer_impl_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
scherkus (not reviewing)
6 years, 5 months ago (2014-07-17 22:40:34 UTC) #1
xhwang
lgtm % nit https://codereview.chromium.org/403573004/diff/1/media/filters/video_renderer_impl_unittest.cc File media/filters/video_renderer_impl_unittest.cc (right): https://codereview.chromium.org/403573004/diff/1/media/filters/video_renderer_impl_unittest.cc#newcode494 media/filters/video_renderer_impl_unittest.cc:494: .Times(AtLeast(0)); Times(AnyNumber())?
6 years, 5 months ago (2014-07-17 22:44:23 UTC) #2
scherkus (not reviewing)
https://codereview.chromium.org/403573004/diff/1/media/filters/video_renderer_impl_unittest.cc File media/filters/video_renderer_impl_unittest.cc (right): https://codereview.chromium.org/403573004/diff/1/media/filters/video_renderer_impl_unittest.cc#newcode494 media/filters/video_renderer_impl_unittest.cc:494: .Times(AtLeast(0)); On 2014/07/17 22:44:23, xhwang wrote: > Times(AnyNumber())? Done.
6 years, 5 months ago (2014-07-17 22:47:04 UTC) #3
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 5 months ago (2014-07-17 22:47:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/403573004/20001
6 years, 5 months ago (2014-07-17 22:49:32 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 03:40:22 UTC) #6
Message was sent while issue was closed.
Change committed as 283998

Powered by Google App Engine
This is Rietveld 408576698