Clean-up coding style at apps folder

Clean-up coding style at apps folder

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284074

[rucifer1217, 2014-07-17 17:31:56]

Please review this.

[marja, 2014-07-18 07:34:05]

https://codereview.chromium.org/403573003/diff/1/apps/app_window_contents.cc
File apps/app_window_contents.cc (right):

https://codereview.chromium.org/403573003/diff/1/apps/app_window_contents.cc#...
apps/app_window_contents.cc:7: #include <utility>
Why is this needed?

https://codereview.chromium.org/403573003/diff/1/apps/launcher.cc
File apps/launcher.cc (right):

https://codereview.chromium.org/403573003/diff/1/apps/launcher.cc#newcode7
apps/launcher.cc:7: #include <utility>
Why is this needed?

https://codereview.chromium.org/403573003/diff/1/apps/saved_files_service.cc
File apps/saved_files_service.cc (right):

https://codereview.chromium.org/403573003/diff/1/apps/saved_files_service.cc#...
apps/saved_files_service.cc:8: #include <hash_map>
Afaics this is not needed; base/containers/hash_tables.h is enough for getting
base::hash_map in (it'll do the necessary includes).

[marja, 2014-07-18 07:46:54]

In addition, you need to sign a CLA before you can contribute:

Individual:

https://developers.google.com/open-source/cla/individual?csw=1

Corporate:

https://developers.google.com/open-source/cla/corporate?csw=1


(For more information, see here:
http://dev.chromium.org/developers/contributing-code/external-contributor-che...
)

I'll be OOO but mek@ can hopefully help you if you have further questions.

[rucifer1217, 2014-07-18 09:06:03]

remove #include <hash_map> at apps/saved_files_service.cc
and i submitted Individual CLA form.

https://codereview.chromium.org/403573003/diff/1/apps/app_window_contents.cc
File apps/app_window_contents.cc (right):

https://codereview.chromium.org/403573003/diff/1/apps/app_window_contents.cc#...
apps/app_window_contents.cc:7: #include <utility>
On 2014/07/18 07:34:04, marja (ooo until 18th of Aug) wrote:
> Why is this needed?
pair<> is need utility.

https://codereview.chromium.org/403573003/diff/1/apps/launcher.cc
File apps/launcher.cc (right):

https://codereview.chromium.org/403573003/diff/1/apps/launcher.cc#newcode7
apps/launcher.cc:7: #include <utility>
On 2014/07/18 07:34:04, marja (ooo until 18th of Aug) wrote:
> Why is this needed?
pair<> is need utility.

https://codereview.chromium.org/403573003/diff/1/apps/saved_files_service.cc
File apps/saved_files_service.cc (right):

https://codereview.chromium.org/403573003/diff/1/apps/saved_files_service.cc#...
apps/saved_files_service.cc:8: #include <hash_map>
On 2014/07/18 07:34:04, marja (ooo until 18th of Aug) wrote:
> Afaics this is not needed; base/containers/hash_tables.h is enough for getting
> base::hash_map in (it'll do the necessary includes).
I will remove this line at next patch.

[Marijn Kruisselbrink, 2014-07-18 09:29:01]

Thanks, LGTM

[rucifer1217, 2014-07-18 09:35:30]

The CQ bit was checked by rucifer1217@gmail.com

[rucifer1217, 2014-07-18 09:35:31]

The CQ bit was unchecked by rucifer1217@gmail.com

[rucifer1217, 2014-07-18 09:36:23]

The CQ bit was checked by rucifer1217@gmail.com

[commit-bot: I haz the power, 2014-07-18 09:37:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rucifer1217@gmail.com/403573003/20001

[rucifer1217, 2014-07-18 09:47:15]

On 2014/07/18 09:29:01, Marijn Kruisselbrink wrote:
> Thanks, LGTM

Thank you.

[commit-bot: I haz the power, 2014-07-18 11:38:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-18 13:06:29]

Change committed as 284074