Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 403553002: Do not wrap text in the flakiness dashboard revision popup (Closed)

Created:
6 years, 5 months ago by pdr.
Modified:
6 years, 5 months ago
Reviewers:
jparent, ojan
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Do not wrap text in the flakiness dashboard revision popup Text wrapping is a little funny in an absolute-positioned element: the available width of an off-screen element is zero which causes wrapping. I created a minimal example of this is at http://pr.gg/wrapgenius.html This behavior is well-known and there are workarounds [1]. The flakiness dashboard popup is similarly affected (see: http://pr.gg/flakywrapping.png). Because the flakiness dashboard revision popup has breaks already, we can just use white-space: nowrap to fix this without any involved workarounds. [1] http://stackoverflow.com/questions/14819574/preserve-normal-word-wrapping-inside-absolutely-positioned-container NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178519

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pdr.
6 years, 5 months ago (2014-07-17 15:49:32 UTC) #1
pdr.
On 2014/07/17 15:49:32, pdr wrote: Ping
6 years, 5 months ago (2014-07-19 16:45:46 UTC) #2
ojan
lgtm
6 years, 5 months ago (2014-07-19 17:07:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/403553002/1
6 years, 5 months ago (2014-07-19 17:07:42 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 17:08:01 UTC) #5
Message was sent while issue was closed.
Change committed as 178519

Powered by Google App Engine
This is Rietveld 408576698