Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 403543002: Make GCTracer persistent. (Closed)

Created:
6 years, 5 months ago by ernstm
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Make GCTracer persistent. This is essentially https://codereview.chromium.org/390823003/. It turns out that it's safe to use a persistent GCTracer instead of creating and destroying GCTracers for each GC, because Scavenge and Mark-Sweep steps never overlap, and the tracking of incremental marking also happens separately for the two types of GC. Tracking of incremental marking will be moved into the GCTracer in a follow-up patch. R=hpayer@chromium.org, mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22465

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove destr and initialize last gc timestamp. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -183 lines) Patch
M src/heap.h View 1 7 chunks +123 lines, -121 lines 0 comments Download
M src/heap.cc View 1 15 chunks +37 lines, -28 lines 0 comments Download
M src/mark-compact.h View 4 chunks +1 line, -10 lines 0 comments Download
M src/mark-compact.cc View 15 chunks +26 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ernstm
PTAL
6 years, 5 months ago (2014-07-17 13:37:10 UTC) #1
Hannes Payer (out of office)
https://codereview.chromium.org/403543002/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/403543002/diff/1/src/heap.cc#newcode6002 src/heap.cc:6002: GCTracer::~GCTracer() { I guess we can remove the destructor. ...
6 years, 5 months ago (2014-07-17 15:26:14 UTC) #2
ernstm
https://codereview.chromium.org/403543002/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/403543002/diff/1/src/heap.cc#newcode6002 src/heap.cc:6002: GCTracer::~GCTracer() { On 2014/07/17 15:26:14, Hannes Payer wrote: > ...
6 years, 5 months ago (2014-07-18 08:32:28 UTC) #3
Hannes Payer (out of office)
lgtm
6 years, 5 months ago (2014-07-18 08:36:27 UTC) #4
ernstm
6 years, 5 months ago (2014-07-18 08:55:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r22465 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698