Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: expectations/gm/ignored-tests.txt

Issue 40353002: Add note to ignored-tests.txt (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: expectations/gm/ignored-tests.txt
===================================================================
--- expectations/gm/ignored-tests.txt (revision 11942)
+++ expectations/gm/ignored-tests.txt (working copy)
@@ -1,5 +1,5 @@
-# Failures of any GM tests/configs listed in this file will be ignored, as if
-# they had been marked "ignore-failure": true in the per-builder
+# Failures of any GM tests/configs listed in this file will be ignored [1], as
+# if they had been marked "ignore-failure": true in the per-builder
# expected-results.json files.
#
# The idea is that, if you modify a GM test in such a way that you know it will
@@ -16,6 +16,12 @@
# For more information, see https://code.google.com/p/skia/issues/detail?id=1600
# ('GM expectations: create tool to suppress failures until new baselines are
# checked in')
+#
+#
+# [1] Differences between renderModes (e.g., normal rendering path and
+# "serialized") are NEVER ignored. See
+# https://code.google.com/p/skia/issues/detail?id=1748 ('gm: add new result
+# type, RenderModeMismatch')
# EXAMPLES: (remove the first '#' on each line)
#
@@ -32,4 +38,4 @@
pdf-poppler
# Added by bsalomon, test case added in https://codereview.chromium.org/30593003
-imagefiltersgraph
+imagefiltersgraph
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698