Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 403523005: DevTools: Consume registered DevTools shortcuts so that they don't trigger default behavior. (Closed)

Created:
6 years, 5 months ago by vsevik
Modified:
6 years, 5 months ago
Reviewers:
apavlov, dgozman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Consume registered DevTools shortcuts so that they don't trigger default behavior. BUG=394313 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178370

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/front_end/ui/ShortcutRegistry.js View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
vsevik
PTAL
6 years, 5 months ago (2014-07-17 11:26:09 UTC) #1
dgozman
lgtm
6 years, 5 months ago (2014-07-17 11:31:05 UTC) #2
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 5 months ago (2014-07-17 12:01:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/403523005/1
6 years, 5 months ago (2014-07-17 12:01:50 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-17 13:10:03 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 13:40:33 UTC) #6
Message was sent while issue was closed.
Change committed as 178370

Powered by Google App Engine
This is Rietveld 408576698