Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 403523003: Move Shadow DOM renderers into rendering/ (Closed)

Created:
6 years, 5 months ago by deepak.sa
Modified:
6 years, 5 months ago
Reviewers:
tkent, esprehn
CC:
blink-reviews, blink-reviews-rendering, zoltan1, blink-reviews-html_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move Shadow DOM renderers into rendering/ There are two renderers in html/shadow/ RenderSliderContainer and RenderSliderThumb. They moved into rendering/ so that they are tracked like any other renderers. BUG=346445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178456

Patch Set 1 #

Total comments: 10

Patch Set 2 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -206 lines) Patch
M Source/core/core.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/html/shadow/SliderThumbElement.h View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/core/html/shadow/SliderThumbElement.cpp View 1 3 chunks +2 lines, -131 lines 0 comments Download
M Source/core/rendering/RenderSlider.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A + Source/core/rendering/RenderSliderContainer.h View 1 2 chunks +13 lines, -10 lines 0 comments Download
A Source/core/rendering/RenderSliderContainer.cpp View 1 1 chunk +144 lines, -0 lines 0 comments Download
A + Source/core/rendering/RenderSliderThumb.h View 1 2 chunks +12 lines, -10 lines 0 comments Download
A + Source/core/rendering/RenderSliderThumb.cpp View 1 1 chunk +27 lines, -42 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
deepak.sa
Please take a look. Thanks!
6 years, 5 months ago (2014-07-17 10:04:54 UTC) #1
tkent
https://codereview.chromium.org/403523003/diff/1/Source/core/rendering/RenderSliderContainer.cpp File Source/core/rendering/RenderSliderContainer.cpp (right): https://codereview.chromium.org/403523003/diff/1/Source/core/rendering/RenderSliderContainer.cpp#newcode1 Source/core/rendering/RenderSliderContainer.cpp:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
6 years, 5 months ago (2014-07-17 23:56:13 UTC) #2
deepak.sa
Thanks for the review! I have made the requested changes. PTAL? Thanks! https://codereview.chromium.org/403523003/diff/1/Source/core/rendering/RenderSliderContainer.cpp File Source/core/rendering/RenderSliderContainer.cpp ...
6 years, 5 months ago (2014-07-18 06:06:57 UTC) #3
tkent
lgtm
6 years, 5 months ago (2014-07-18 06:19:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/403523003/20001
6 years, 5 months ago (2014-07-18 06:19:49 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-18 07:23:42 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 07:59:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17655)
6 years, 5 months ago (2014-07-18 07:59:40 UTC) #8
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 5 months ago (2014-07-18 08:00:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/403523003/20001
6 years, 5 months ago (2014-07-18 08:01:14 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-18 08:43:44 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 09:40:19 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17670)
6 years, 5 months ago (2014-07-18 09:40:20 UTC) #13
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 5 months ago (2014-07-18 13:45:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deepak.sa@samsung.com/403523003/20001
6 years, 5 months ago (2014-07-18 13:46:06 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-18 15:05:59 UTC) #16
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 16:25:59 UTC) #17
Message was sent while issue was closed. 
Change committed as 178456

Powered by Google App Engine
This is Rietveld 408576698