Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 403503003: Avoid merging chrome_browser_desktop_linux_sources lists (Closed)

Created:
6 years, 5 months ago by Jiang Jiang
Modified:
6 years, 5 months ago
Reviewers:
Lei Zhang, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Avoid merging chrome_browser_desktop_linux_sources lists chrome_browser_desktop_linux_sources variable is defined in both chrome_browser.gypi and chrome_browser_ui.gypi. If we keep the same name the lists will be merged in gyp builds, resulting the same list compiling twice for both browser and browser_ui targets. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284044

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Jiang Jiang
6 years, 5 months ago (2014-07-17 15:33:27 UTC) #1
Jiang Jiang
6 years, 5 months ago (2014-07-17 19:06:39 UTC) #2
Lei Zhang
lgtm
6 years, 5 months ago (2014-07-17 19:10:56 UTC) #3
Jiang Jiang
The CQ bit was checked by jiangj@opera.com
6 years, 5 months ago (2014-07-17 19:18:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/403503003/1
6 years, 5 months ago (2014-07-17 19:20:46 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 23:21:31 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 23:39:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/172152)
6 years, 5 months ago (2014-07-17 23:39:52 UTC) #8
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-17 23:42:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/403503003/1
6 years, 5 months ago (2014-07-17 23:47:08 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 00:14:31 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 00:37:35 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/172152)
6 years, 5 months ago (2014-07-18 00:37:36 UTC) #13
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-18 00:38:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/403503003/1
6 years, 5 months ago (2014-07-18 00:40:06 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 01:00:00 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 01:19:51 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/172152)
6 years, 5 months ago (2014-07-18 01:19:52 UTC) #18
Jiang Jiang
The CQ bit was checked by jiangj@opera.com
6 years, 5 months ago (2014-07-18 09:35:57 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiangj@opera.com/403503003/1
6 years, 5 months ago (2014-07-18 09:37:07 UTC) #20
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 09:38:35 UTC) #21
Message was sent while issue was closed.
Change committed as 284044

Powered by Google App Engine
This is Rietveld 408576698