Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3387)

Unified Diff: ash/wm/overview/window_selector_unittest.cc

Issue 403493006: Visual improvements to text filtering in Ash overview mode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: modified test Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ash/wm/overview/window_selector.cc ('K') | « ash/wm/overview/window_selector.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/overview/window_selector_unittest.cc
diff --git a/ash/wm/overview/window_selector_unittest.cc b/ash/wm/overview/window_selector_unittest.cc
index 93dba4d88c0e80a60ec7f02618a6de8a55f5abf9..2b92354eb16b2512839627e3a594b5cff2b44c27 100644
--- a/ash/wm/overview/window_selector_unittest.cc
+++ b/ash/wm/overview/window_selector_unittest.cc
@@ -897,22 +897,21 @@ TEST_F(WindowSelectorTest, BasicArrowKeyNavigation) {
ui::VKEY_LEFT,
ui::VKEY_UP
};
- // Expected window layout:
+ // Expected window layout, assuming that the text filtering feature is
+ // enabled by default (i.e., --ash-disable-text-filtering-in-overview-mode
+ // is not being used).
flackr 2014/08/08 17:43:59 Could you extend this to still have 3 rows (with 1
tdanderson 2014/08/08 19:25:44 Done.
+ // +-------+ +-------+ +-------+ +-------+
+ // | 1 | | 2 | | 3 | | 4 |
+ // +-------+ +-------+ +-------+ +-------+
// +-------+ +-------+ +-------+
- // | 1 | | 2 | | 3 |
+ // | 5 | | 6 | | 7 |
// +-------+ +-------+ +-------+
- // +-------+ +-------+ +-------+
- // | 4 | | 5 | | 6 |
- // +-------+ +-------+ +-------+
- // +-------+
- // | 7 |
- // +-------+
// Index for each window during a full loop plus wrapping around.
int index_path_for_direction[][test_windows + 1] = {
{1, 2, 3, 4, 5, 6, 7, 1}, // Right
- {1, 4, 7, 2, 5, 3, 6, 1}, // Down
+ {1, 5, 2, 6, 3, 7, 4, 1}, // Down
{7, 6, 5, 4, 3, 2, 1, 7}, // Left
- {6, 3, 5, 2, 7, 4, 1, 6} // Up
+ {4, 7, 3, 6, 2, 5, 1, 4} // Up
};
for (size_t key_index = 0; key_index < arraysize(arrow_keys); key_index++) {
« ash/wm/overview/window_selector.cc ('K') | « ash/wm/overview/window_selector.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698