Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 403493004: generate_stubs: Add a new option --export-macro. (Closed)

Created:
6 years, 5 months ago by Robert Sesek
Modified:
6 years, 5 months ago
Reviewers:
awong, DaleCurtis
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

generate_stubs: Add a new option --export-macro. This allows specifying the shared_library MODULE_EXPORT constant so that stub symbols can be called across shared library boundaries. BUG=none R=ajwong@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284210

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -16 lines) Patch
M tools/generate_stubs/generate_stubs.py View 15 chunks +39 lines, -13 lines 0 comments Download
M tools/generate_stubs/generate_stubs_unittest.py View 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Robert Sesek
6 years, 5 months ago (2014-07-17 18:37:55 UTC) #1
Robert Sesek
awong is OOO. Dale: You've done a few reviews/changes to this file recently, would you ...
6 years, 5 months ago (2014-07-18 15:20:25 UTC) #2
DaleCurtis
lgtm
6 years, 5 months ago (2014-07-18 18:31:19 UTC) #3
Robert Sesek
The CQ bit was checked by rsesek@chromium.org
6 years, 5 months ago (2014-07-18 18:35:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/403493004/1
6 years, 5 months ago (2014-07-18 18:38:01 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 21:45:09 UTC) #6
Message was sent while issue was closed.
Change committed as 284210

Powered by Google App Engine
This is Rietveld 408576698