Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: Source/devtools/front_end/ui/Dialog.js

Issue 403493003: DevTools: Fix DefaultFocusedViewStack handling for dialogs. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/devtools/front_end/ui/UIUtils.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 } 80 }
81 81
82 WebInspector.Dialog.hide = function() 82 WebInspector.Dialog.hide = function()
83 { 83 {
84 if (!WebInspector.Dialog._instance) 84 if (!WebInspector.Dialog._instance)
85 return; 85 return;
86 WebInspector.Dialog._instance._hide(); 86 WebInspector.Dialog._instance._hide();
87 } 87 }
88 88
89 WebInspector.Dialog.prototype = { 89 WebInspector.Dialog.prototype = {
90 focus: function()
91 {
92 this._element.focus();
dgozman 2014/07/17 11:43:05 Maybe |this._delegate.focus()| ?
93 },
94
90 _hide: function() 95 _hide: function()
91 { 96 {
92 if (this._isHiding) 97 if (this._isHiding)
93 return; 98 return;
94 this._isHiding = true; 99 this._isHiding = true;
95 100
96 this._delegate.willHide(); 101 this._delegate.willHide();
97 102
98 delete WebInspector.Dialog._instance; 103 delete WebInspector.Dialog._instance;
99 WebInspector.GlassPane.DefaultFocusedViewStack.pop(); 104 WebInspector.GlassPane.DefaultFocusedViewStack.pop();
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
201 { 206 {
202 return WebInspector.Dialog._modalHostView; 207 return WebInspector.Dialog._modalHostView;
203 }; 208 };
204 209
205 WebInspector.Dialog.modalHostRepositioned = function() 210 WebInspector.Dialog.modalHostRepositioned = function()
206 { 211 {
207 if (WebInspector.Dialog._instance) 212 if (WebInspector.Dialog._instance)
208 WebInspector.Dialog._instance._position(); 213 WebInspector.Dialog._instance._position();
209 }; 214 };
210 215
OLDNEW
« no previous file with comments | « no previous file | Source/devtools/front_end/ui/UIUtils.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698