Issue 403493003: DevTools: Fix DefaultFocusedViewStack handling for dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 403493003: DevTools: Fix DefaultFocusedViewStack handling for dialogs. (Closed)

Created:
6 years, 5 months ago by vsevik

Modified:
6 years, 5 months ago

Reviewers:
apavlov, dgozman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Fix DefaultFocusedViewStack handling for dialogs. BUG=392793 R=apavlov, dgozman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178372

Patch Set 1 #

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	Source/devtools/front_end/ui/Dialog.js	View		1 chunk	+5 lines, -0 lines	1 comment	Download
	M	Source/devtools/front_end/ui/UIUtils.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dgozman

lgtm https://codereview.chromium.org/403493003/diff/1/Source/devtools/front_end/ui/Dialog.js File Source/devtools/front_end/ui/Dialog.js (right): https://codereview.chromium.org/403493003/diff/1/Source/devtools/front_end/ui/Dialog.js#newcode92 Source/devtools/front_end/ui/Dialog.js:92: this._element.focus(); Maybe |this._delegate.focus()| ?

6 years, 5 months ago (2014-07-17 11:43:05 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/403493003/1

6 years, 5 months ago (2014-07-17 12:01:58 UTC) #4

Message was sent while issue was closed.

Change committed as 178372

Expand Messages | Collapse Messages