gn: bootstrap: fixes, added mac support

gn: bootstrap: fixes, added mac support

bootstrap.py:
+ Fixed build (missing/wrong compile flags)
+ Added -s option to stop before trying to rebuild GN with GN
+ -v option passes -v to ninja
+ Use env vars CC, CXX, CXXFLAGS
+ Added mac support

R=brettw@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285356

[brettw, 2014-07-17 22:14:49]

Looks nice! I only have one request (alternate suggestions welcome).

https://codereview.chromium.org/403463005/diff/1/tools/gn/bootstrap/bootstrap.py
File tools/gn/bootstrap/bootstrap.py (right):

https://codereview.chromium.org/403463005/diff/1/tools/gn/bootstrap/bootstrap...
tools/gn/bootstrap/bootstrap.py:57: parser.add_option('-s', '--no-bootstrap',
action='store_true',
Typing "bootstrap.py --no-bootstrap" seems weird to me. Maybe --no-rebuild would
be a better name?

[kal, 2014-07-17 22:22:30]

On 2014/07/17 22:14:49, brettw wrote:
> Looks nice! I only have one request (alternate suggestions welcome).
> 
>
https://codereview.chromium.org/403463005/diff/1/tools/gn/bootstrap/bootstrap.py
> File tools/gn/bootstrap/bootstrap.py (right):
> 
>
https://codereview.chromium.org/403463005/diff/1/tools/gn/bootstrap/bootstrap...
> tools/gn/bootstrap/bootstrap.py:57: parser.add_option('-s', '--no-bootstrap',
> action='store_true',
> Typing "bootstrap.py --no-bootstrap" seems weird to me. Maybe --no-rebuild
would
> be a better name?

OK I'll change to --no-rebuild. That was what I called it first anyway. :)

[kal, 2014-07-21 18:59:12]

The CQ bit was checked by kcconley@gmail.com

[kal, 2014-07-21 18:59:15]

The CQ bit was unchecked by kcconley@gmail.com

[kal, 2014-07-21 19:00:58]

The CQ bit was checked by kcconley@gmail.com

[kal, 2014-07-21 19:01:05]

The CQ bit was unchecked by kcconley@gmail.com

[kal, 2014-07-24 10:15:03]

Is there still something I need to do here to get this committed?

[brettw, 2014-07-24 16:36:55]

lgtm

Oh, sorry. It wasn't clear from your comments that you had already re-uploaded a
new patch.

[commit-bot: I haz the power, 2014-07-24 16:37:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kcconley@gmail.com/403463005/20001

[commit-bot: I haz the power, 2014-07-24 20:07:58]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

[commit-bot: I haz the power, 2014-07-24 20:17:00]

Change committed as 285356