Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 403423002: Disable OccludedTilesNotMarkedAsRequired test on Windows. (Closed)

Created:
6 years, 5 months ago by jbedley
Modified:
6 years, 5 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Project:
chromium
Visibility:
Public.

Description

Disable OccludedTilesNotMarkedAsRequired test on Windows. The second part of https://codereview.chromium.org/389933004 to disable some failing unit tests on Windows. BUG=393733 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284505

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cc/layers/picture_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
jbedley
The CQ bit was checked by jbedley@chromium.org
6 years, 5 months ago (2014-07-21 15:37:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbedley@chromium.org/403423002/1
6 years, 5 months ago (2014-07-21 15:38:28 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 15:38:29 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 5 months ago (2014-07-21 15:38:29 UTC) #4
jbedley
enne, would you mind reviewing this while danakj is away?
6 years, 5 months ago (2014-07-21 15:57:04 UTC) #5
vmpstr
lgtm, seem like danakj just forgot to use the macro defined in https://codereview.chromium.org/389933004?
6 years, 5 months ago (2014-07-21 16:37:27 UTC) #6
jbedley
On 2014/07/21 16:37:27, vmpstr wrote: > lgtm, seem like danakj just forgot to use the ...
6 years, 5 months ago (2014-07-21 17:03:30 UTC) #7
jbedley
The CQ bit was checked by jbedley@chromium.org
6 years, 5 months ago (2014-07-21 17:03:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbedley@chromium.org/403423002/1
6 years, 5 months ago (2014-07-21 17:04:34 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 19:29:18 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 21:45:05 UTC) #11
Message was sent while issue was closed.
Change committed as 284505

Powered by Google App Engine
This is Rietveld 408576698