Adds tools/whitespace.txt to the list of files that trigger compile

Adds tools/whitespace.txt to the list of files that trigger compile

This file is used by the cq to measure loads and other stats. We want
changes to it to result in a compile and test.

BUG=383609
TEST=none
R=iannucci@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284522

[sheyang, 2014-07-21 18:15:28]

lgtm

Does/will this change also affect blink?

[sky, 2014-07-21 18:17:51]

Right now the only bot running the analyze step is the linux clang bot. I want
to turn it on for all try bots (that run the same recipe), but it'll be a while.

[sky, 2014-07-21 18:17:58]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-07-21 18:19:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sky@chromium.org/403393007/1

[commit-bot: I haz the power, 2014-07-21 18:19:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-21 18:19:55]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[iannucci, 2014-07-21 18:27:47]

lgtm

[sky, 2014-07-21 18:29:17]

The CQ bit was unchecked by sky@chromium.org

[sky, 2014-07-21 18:29:22]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-07-21 18:30:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sky@chromium.org/403393007/1

[commit-bot: I haz the power, 2014-07-21 22:38:50]

Change committed as 284522

[Nico, 2014-07-22 13:41:16]

On 2014/07/21 22:38:50, I haz the power (commit-bot) wrote:
> Change committed as 284522

We have used build/whitespace_file.txt for this for years. Why the new
whitespace file?

[sky, 2014-07-22 16:13:46]

No idea there. Hopefully one of the guys that created the new file
could tell you.

On Tue, Jul 22, 2014 at 6:41 AM,  <thakis@chromium.org> wrote:
> On 2014/07/21 22:38:50, I haz the power (commit-bot) wrote:
>>
>> Change committed as 284522
>
>
> We have used build/whitespace_file.txt for this for years. Why the new
> whitespace file?
>
> https://codereview.chromium.org/403393007/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2014-07-22 16:19:27]

We just pick a folder without OWNER restriction. The tools/whitespace.txt
will never be committed so it shouldn't affect the repo.

Best regards,

Sheng


On Tue, Jul 22, 2014 at 9:13 AM, Scott Violet <sky@chromium.org> wrote:

> No idea there. Hopefully one of the guys that created the new file
> could tell you.
>
> On Tue, Jul 22, 2014 at 6:41 AM,  <thakis@chromium.org> wrote:
> > On 2014/07/21 22:38:50, I haz the power (commit-bot) wrote:
> >>
> >> Change committed as 284522
> >
> >
> > We have used build/whitespace_file.txt for this for years. Why the new
> > whitespace file?
> >
> > https://codereview.chromium.org/403393007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2014-07-22 16:36:53]

You could make the file have a * in OWNERS. That gives the same effect.

  -Scott

On Tue, Jul 22, 2014 at 9:19 AM, Sheng Yang <sheyang@google.com> wrote:
> We just pick a folder without OWNER restriction. The tools/whitespace.txt
> will never be committed so it shouldn't affect the repo.
>
> Best regards,
>
> Sheng
>
>
> On Tue, Jul 22, 2014 at 9:13 AM, Scott Violet <sky@chromium.org> wrote:
>>
>> No idea there. Hopefully one of the guys that created the new file
>> could tell you.
>>
>> On Tue, Jul 22, 2014 at 6:41 AM,  <thakis@chromium.org> wrote:
>> > On 2014/07/21 22:38:50, I haz the power (commit-bot) wrote:
>> >>
>> >> Change committed as 284522
>> >
>> >
>> > We have used build/whitespace_file.txt for this for years. Why the new
>> > whitespace file?
>> >
>> > https://codereview.chromium.org/403393007/
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-07-28 18:19:29]

Also, build/OWNERS currently contains * too, so build/whitespace_file.txt would
work just as well?