Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 403393004: Update Layout test and webkit test after ICU52 roll (Closed)

Created:
6 years, 5 months ago by jungshik at Google
Modified:
6 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Update Layout test and webkit test after ICU52 roll Now that ICU was rolled to ICU 52, two layout tests marked as failure pass beause the expectation was updated in advance to prepare for ICU 52 update. Likewise, a test for shortStandAloneMonth names in ru_RU should be re-enabled. BUG=378919, 377042 TEST=1.LayoutTest: fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-* 2. webkit_unit_tests: LocaleICU* TBR=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178574

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/web/tests/LocaleICUTest.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jungshik at Google
I'll update the expected results for tests requiring manual rebaselining separately.
6 years, 5 months ago (2014-07-21 16:52:29 UTC) #1
jungshik at Google
The CQ bit was checked by jshin@chromium.org
6 years, 5 months ago (2014-07-21 16:59:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/403393004/1
6 years, 5 months ago (2014-07-21 17:00:49 UTC) #3
commit-bot: I haz the power
Change committed as 178574
6 years, 5 months ago (2014-07-21 18:03:40 UTC) #4
tkent
6 years, 5 months ago (2014-07-22 00:50:38 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698