Issue 403393002: Always set the container size for a pAR=none image to the intrinsic size

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 403393002: Always set the container size for a pAR=none image to the intrinsic size (Closed)

Created:
6 years, 5 months ago by fs

Modified:
6 years, 5 months ago

Reviewers:
pdr., f(malita)

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, rwlbuis, Stephen Chennney, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Always set the container size for a pAR=none image to the intrinsic size When updating the viewport for an <svg:image> that has preserveAspectRatio set to 'none' only update the container size from the intrinsic size, and never the actual viewport (size) as specified by the 'width' and 'height' attributes. Previously a change to the actual viewport (when pAR=none) would cause an update to the container size from the actual viewport size, since the image/container size was previously set to the intrinsic size. Also simplify the request for the intrinsic size a bit. BUG=395139 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178629

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -14 lines)			Patch
A	LayoutTests/svg/custom/svg-image-par-resize.html	View	1 chunk	+22 lines, -0 lines	0 comments	Download
A +	LayoutTests/svg/custom/svg-image-par-resize-expected.txt	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/rendering/svg/RenderSVGImage.cpp	View	1 chunk	+12 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/403393002/1

6 years, 5 months ago (2014-07-22 07:02:28 UTC) #4

Message was sent while issue was closed.

Change committed as 178629

Expand Messages | Collapse Messages