Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 403383002: Implement DOMRect of geometry interfaces. (Closed)

Created:
6 years, 5 months ago by zino
Modified:
6 years, 5 months ago
Reviewers:
Rik, abarth-chromium
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Implement DOMRect of geometry interfaces. The DOMRect can represent a rectangle. The specification: http://dev.w3.org/fxtf/geometry/ Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/V_bJNtOg0oM BUG=388780 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178770

Patch Set 1 #

Patch Set 2 : adding constructor and some tests #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+451 lines, -0 lines) Patch
A LayoutTests/fast/dom/geometry-interfaces-dom-rect.html View 1 1 chunk +166 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/geometry-interfaces-dom-rect-expected.txt View 1 1 chunk +134 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
A Source/core/dom/DOMRect.h View 1 chunk +28 lines, -0 lines 0 comments Download
A Source/core/dom/DOMRect.cpp View 1 chunk +20 lines, -0 lines 0 comments Download
A Source/core/dom/DOMRect.idl View 1 chunk +16 lines, -0 lines 0 comments Download
A Source/core/dom/DOMRectReadOnly.h View 1 1 chunk +39 lines, -0 lines 0 comments Download
A Source/core/dom/DOMRectReadOnly.cpp View 1 1 chunk +23 lines, -0 lines 0 comments Download
A Source/core/dom/DOMRectReadOnly.idl View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
zino
Please take a look. Thank you.
6 years, 5 months ago (2014-07-21 12:58:41 UTC) #1
abarth-chromium
lgtm
6 years, 5 months ago (2014-07-21 17:27:32 UTC) #2
zino
Dear Rik, I added a constructor to DOMRectReadOnly as well. Could you please review?
6 years, 5 months ago (2014-07-22 02:12:58 UTC) #3
Rik
lgtm
6 years, 5 months ago (2014-07-22 02:16:03 UTC) #4
zino
The CQ bit was checked by jinho.bang@samsung.com
6 years, 5 months ago (2014-07-23 10:41:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/403383002/60001
6 years, 5 months ago (2014-07-23 10:41:58 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 15:44:36 UTC) #7
Message was sent while issue was closed.
Change committed as 178770

Powered by Google App Engine
This is Rietveld 408576698