Issue 403343005: Make manual isSVG*Element() helpers as efficient as the generated ones

Issue 403343005: Make manual isSVG*Element() helpers as efficient as the generated ones (Closed)

Created:
6 years, 5 months ago by Inactive

Modified:
6 years, 5 months ago

Reviewers:
pdr., abarth-chromium

CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, krit, dstockwell, ed+blinkwatch_opera.com, Eric Willigers, f(malita), fs, gyuyoung.kim_webkit.org, kouhei+svg_chromium.org, Mike Lawther (Google), pdr., rjwright, rwlbuis, Stephen Chennney, shans, Steve Block, Timothy Loh

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Make manual isSVG*Element() helpers as efficient as the generated ones Make manual isSVG*Element() helpers as efficient as the generated ones by introducing a DEFINE_SVGELEMENT_TYPE_CASTS_WITH_FUNCTION() macro, similarly to the DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(). This new macro is used instead of DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION() for SVG types so that the isSVG*Element() helpers leverage the faster SVGElement::hasTagName(SVGQualifiedName) when possible (i.e. when the input is an SVGElement*). This is a follow-up to: https://src.chromium.org/viewvc/blink?view=rev&revision=178540 R=pdr@chromium.org, abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178580

Patch Set 1 #

Patch Set 2 : Fix macro name #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -28 lines)			Patch
M	Source/core/svg/SVGAnimateElement.h	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	Source/core/svg/SVGAnimateElement.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/svg/SVGElement.h	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	Source/core/svg/SVGFELightElement.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/svg/SVGGradientElement.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/svg/SVGGraphicsElement.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/svg/SVGPolyElement.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/svg/SVGTextContentElement.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/svg/SVGTextPositioningElement.h	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/svg/animation/SVGSMILElement.h	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/403343005/20001

6 years, 5 months ago (2014-07-21 19:55:58 UTC) #4

Message was sent while issue was closed.

Change committed as 178580

Expand Messages | Collapse Messages