Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3886)

Unified Diff: base/android/java/src/org/chromium/base/NativeCall.java

Issue 403323005: Observer Support for DistilledPagePrefs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: moved observerwrapper to inner class, renamed observer wrapper, styling, build.gn added Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/java/src/org/chromium/base/NativeCall.java
diff --git a/base/android/java/src/org/chromium/base/AccessedByNative.java b/base/android/java/src/org/chromium/base/NativeCall.java
similarity index 58%
copy from base/android/java/src/org/chromium/base/AccessedByNative.java
copy to base/android/java/src/org/chromium/base/NativeCall.java
index 3e163fc404a02e1cfe14584b5dc5fa573ed16abe..e5b1d1aad37ce50480ed79cb9aa9f83e47b4c75b 100644
--- a/base/android/java/src/org/chromium/base/AccessedByNative.java
+++ b/base/android/java/src/org/chromium/base/NativeCall.java
@@ -1,4 +1,4 @@
-// Copyright 2012 The Chromium Authors. All rights reserved.
+// Copyright 2014 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -10,11 +10,12 @@ import java.lang.annotation.RetentionPolicy;
import java.lang.annotation.Target;
/**
- * @AccessedByNative is used to ensure proguard will keep this field, since it's
- * only accessed by native.
+ * @NativeCall is used by the JNI generator to create the necessary JNI bindings
+ * so a native function can be bound to a Java inner class.
nyquist 2014/07/23 17:30:45 Nit: Mention that you can specify for which native
sunangel 2014/07/23 18:04:31 Done.
*/
-@Target(ElementType.FIELD)
+@Target(ElementType.METHOD)
@Retention(RetentionPolicy.CLASS)
-public @interface AccessedByNative {
+public @interface NativeCall {
+
public String value() default "";
nyquist 2014/07/23 17:30:45 Nit: Could you add a comment about this? The value
sunangel 2014/07/23 18:04:31 Done.
}

Powered by Google App Engine
This is Rietveld 408576698