Observer Support for DistilledPagePrefs

components/dom_distiller/core/distilled_page_prefs_android.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DOM_DISTILLER_CORE_DISTILLED_PAGE_PREFS_ANDROID_H_
 #define COMPONENTS_DOM_DISTILLER_CORE_DISTILLED_PAGE_PREFS_ANDROID_H_
 
 #include <jni.h>
 
 #include "base/android/scoped_java_ref.h"
 #include "components/dom_distiller/core/distilled_page_prefs.h"
 
 namespace dom_distiller {
 namespace android {
 
 class DistilledPagePrefsAndroid {
  public:
   DistilledPagePrefsAndroid(JNIEnv* env,
                             jobject obj,
-                            DistilledPagePrefs* distillerPagePrefsPtr);
+                            DistilledPagePrefs* distilled_page_prefs_ptr);
   virtual ~DistilledPagePrefsAndroid();
   static bool Register(JNIEnv* env);
   void SetTheme(JNIEnv* env, jobject obj, jint theme);
   jint GetTheme(JNIEnv* env, jobject obj);
+  void AddObserver(JNIEnv* env, jobject obj, jlong obs);
+  void RemoveObserver(JNIEnv* env, jobject obj, jlong obs);
 
  private:
   DistilledPagePrefs* distilled_page_prefs_;
 
   DISALLOW_COPY_AND_ASSIGN(DistilledPagePrefsAndroid);
 };
 
+class DistilledPagePrefsObserverAndroid : public DistilledPagePrefs::Observer {

[nyquist, 2014/07/23 17:30:46]

Could you file a bug and assign to me about making NativeCall supporting inner
C++ classes? This class name is just super long now, but not your fault. You
don't have to refer to the bug in your code.

[sunangel, 2014/07/23 18:04:31]

It is bug 396697. Let me know if I did not do it right.
On 2014/07/23 17:30:46, nyquist wrote:

+ public:
+  DistilledPagePrefsObserverAndroid(JNIEnv* env, jobject obj);
+  virtual ~DistilledPagePrefsObserverAndroid();
+
+  // DistilledPagePrefs::Observer

[nyquist, 2014/07/23 17:30:46]

Nit: End comment with .
Also, how about something on the form: "DistilledPagePrefs::Observer
implementation."?

[sunangel, 2014/07/23 18:04:31]

Done.

+  virtual void OnChangeTheme(DistilledPagePrefs::Theme new_theme) OVERRIDE;
+
+  virtual void DestroyObserverAndroid(JNIEnv* env, jobject obj);
+
+ private:
+  base::android::ScopedJavaGlobalRef<jobject> java_ref_;
+};
+
 }  // namespace android
 }  // namespace dom_distiller
 
 #endif  // COMPONENTS_DOM_DISTILLER_CORE_DISTILLED_PAGE_PREFS_ANDROID_H_