Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 403323003: Remove 'WebURLRequest::TargetType' from 'content::RenderFrameImpl'. (Closed)

Created:
6 years, 5 months ago by Mike West
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove 'WebURLRequest::TargetType' from 'content::RenderFrameImpl'. 'WebURLRequest::TargetType' has been dropped in Blink in favor of 'RequestContext' and 'FrameType', matching the Fetch specification's changes, and allowing both more granularity in various Blink-side checks and more clarity around the thing that caused a request, and the frame that the request affects. This CL should have zero practical effect, as it's simply hoisting the translation work that 'WebURLRequest::setTargetType' is already doing up into the content layer to bring us one step closer to removing the concept entirely. There's still one call to 'ResourceType::FromTargetType' in RenderFrameImpl that this CL doesn't remove: that method will be converted to RequestContext in a future CL. BUG=390497 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284520

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M content/renderer/render_frame_impl.cc View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike West
jam@ mind taking a look at this CL? -mike
6 years, 5 months ago (2014-07-21 16:11:30 UTC) #1
jam
lgtm
6 years, 5 months ago (2014-07-21 17:09:08 UTC) #2
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 5 months ago (2014-07-21 17:38:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/403323003/1
6 years, 5 months ago (2014-07-21 17:39:55 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 22:36:46 UTC) #5
Message was sent while issue was closed.
Change committed as 284520

Powered by Google App Engine
This is Rietveld 408576698