Issue 403233002: Do not use \u unicode characters directly in libaddressinput unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 403233002: Do not use \u unicode characters directly in libaddressinput unit tests. (Closed)

Created:
6 years, 5 months ago by please use gerrit instead

Modified:
6 years, 5 months ago

Reviewers:
rouslan, Evan Stade

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Do not use \u unicode characters directly in libaddressinput unit tests. VisualStudio does not understand it \u escape sequences like \u00E8 in UTF8 strings. The fix is to use Wide strings and convert them into UTF8 using base::WideToUTF8() utility. BUG=395401 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284629

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	third_party/libaddressinput/chromium/chrome_address_validator_unittest.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
	M	third_party/libaddressinput/chromium/string_compare_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/403233002/1

6 years, 5 months ago (2014-07-22 01:27:23 UTC) #4

Message was sent while issue was closed.

Change committed as 284629

Expand Messages | Collapse Messages