Add WebDataSource::appendRedirect for cross-process redirects.

Add WebDataSource::appendRedirect for cross-process redirects.

BUG=104576
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160603

[Charlie Reis, 2013-10-24 20:45:23]

Darin, I think we'll need this to fix http://crbug.com/104576.  We aren't
propagating the redirect chain during a cross-process server redirect, so the
history database doesn't realize that the user's typed URL is part of the
commit.

I'll end up using this in the new RenderViewImpl (in didCreateDataSource) to
append the redirects that happened in the old process.

[darin (slow to review), 2013-10-25 03:08:11]

OK, LGTM
On Oct 24, 2013 1:45 PM, <creis@chromium.org> wrote:

> Reviewers: darin,
>
> Message:
> Darin, I think we'll need this to fix http://crbug.com/104576.  We aren't
> propagating the redirect chain during a cross-process server redirect, so
> the
> history database doesn't realize that the user's typed URL is part of the
> commit.
>
> I'll end up using this in the new RenderViewImpl (in didCreateDataSource)
> to
> append the redirects that happened in the old process.
>
> Description:
> Add WebDataSource::appendRedirect for cross-process redirects.
>
> BUG=104576
>
> Please review this at
https://codereview.chromium.**org/40323004/<https://codereview.chromium.org/4...
>
> SVN Base:
https://chromium.googlesource.**com/chromium/blink.git@master<https://chromiu...
>
> Affected files (+29, -0 lines):
>   M Source/web/WebDataSourceImpl.h
>   M Source/web/WebDataSourceImpl.**cpp
>   M Source/web/tests/WebFrameTest.**cpp
>   M public/web/WebDataSource.h
>
>
> Index: Source/web/WebDataSourceImpl.**cpp
> diff --git a/Source/web/**WebDataSourceImpl.cpp b/Source/web/**
> WebDataSourceImpl.cpp
> index 95ae7269469589c30ee9e95761e86c**34d203bd9e..**
> d53239788d60c3129c0152b91f9da3**3a7ddb4669 100644
> --- a/Source/web/**WebDataSourceImpl.cpp
> +++ b/Source/web/**WebDataSourceImpl.cpp
> @@ -81,6 +81,11 @@ WebURL WebDataSourceImpl::**unreachableURL() const
>      return DocumentLoader::**unreachableURL();
>  }
>
> +void WebDataSourceImpl::**appendRedirect(const WebURL& url)
> +{
> +    DocumentLoader::**appendRedirect(url);
> +}
> +
>  void WebDataSourceImpl::**redirectChain(WebVector<**WebURL>& result)
> const
>  {
>      result.assign(m_redirectChain)**;
> Index: Source/web/WebDataSourceImpl.h
> diff --git a/Source/web/**WebDataSourceImpl.h b/Source/web/**
> WebDataSourceImpl.h
> index 2c4cd8075122077894e03f3bbb3a6c**7d21ba6c4c..**
> 555d6db61907e4cf2dab6549c278a3**48ed567d5a 100644
> --- a/Source/web/**WebDataSourceImpl.h
> +++ b/Source/web/**WebDataSourceImpl.h
> @@ -61,6 +61,7 @@ public:
>      virtual const WebURLResponse& response() const;
>      virtual bool hasUnreachableURL() const;
>      virtual WebURL unreachableURL() const;
> +    virtual void appendRedirect(const WebURL&);
>      virtual void redirectChain(WebVector<**WebURL>&) const;
>      virtual bool isClientRedirect() const;
>      virtual bool replacesCurrentHistoryItem() const;
> Index: Source/web/tests/WebFrameTest.**cpp
> diff --git a/Source/web/tests/**WebFrameTest.cpp b/Source/web/tests/**
> WebFrameTest.cpp
> index 995878ddd6743a00dfa1051fd39e32**87e12b7f5a..**
> 4b3853d9d01b5c8f15a7c0025afe54**cb1418f2de 100644
> --- a/Source/web/tests/**WebFrameTest.cpp
> +++ b/Source/web/tests/**WebFrameTest.cpp
> @@ -2356,6 +2356,25 @@ TEST_F(WebFrameTest, ReloadWhileProvisional)
>          webViewHelper.webView()->**mainFrame()->dataSource()->**
> request().url());
>  }
>
> +TEST_F(WebFrameTest, AppendRedirects)
> +{
> +    const std::string firstURL = "about:blank";
> +    const std::string secondURL = "http://www.test.com";
> +
> +    FrameTestHelpers::**WebViewHelper webViewHelper;
> +    webViewHelper.**initializeAndLoad(firstURL, true);
> +
> +    WebDataSource* dataSource = webViewHelper.webView()->**
> mainFrame()->dataSource();
> +    ASSERT_TRUE(dataSource);
> +    dataSource->appendRedirect(**toKURL(secondURL));
> +
> +    WebVector<WebURL> redirects;
> +    dataSource->redirectChain(**redirects);
> +    ASSERT_EQ(2U, redirects.size());
> +    EXPECT_EQ(toKURL(firstURL), toKURL(redirects[0].spec().**data()));
> +    EXPECT_EQ(toKURL(secondURL), toKURL(redirects[1].spec().**data()));
> +}
> +
>  TEST_F(WebFrameTest, IframeRedirect)
>  {
>      registerMockedHttpURLLoad("**iframe_redirect.html");
> Index: public/web/WebDataSource.h
> diff --git a/public/web/WebDataSource.h b/public/web/WebDataSource.h
> index 8ddce66bcad1956b616a510e44bb6e**72c27f35c0..**
> 9c5e2364536e3135f63364fee9d51c**bb6a1734dd 100644
> --- a/public/web/WebDataSource.h
> +++ b/public/web/WebDataSource.h
> @@ -68,6 +68,10 @@ public:
>      virtual bool hasUnreachableURL() const = 0;
>      virtual WebURL unreachableURL() const = 0;
>
> +    // Allows the embedder to append redirects to the chain as a
> navigation
> +    // is starting, in case it is being transferred from another process.
> +    virtual void appendRedirect(const WebURL&) = 0;
> +
>      // Returns all redirects that occurred (both client and server) before
>      // at last committing the current page.  This will contain one entry
>      // for each intermediate URL, and one entry for the last URL (so if
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-10-25 16:39:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/creis@chromium.org/40323004/30001

[commit-bot: I haz the power, 2013-10-25 17:35:17]

Change committed as 160603