Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Side by Side Diff: Source/core/html/track/WebVTTParser.h

Issue 40323003: Remove virtual destructor for WebVTTParser (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 public: 50 public:
51 virtual ~WebVTTParserClient() { } 51 virtual ~WebVTTParserClient() { }
52 52
53 virtual void newCuesParsed() = 0; 53 virtual void newCuesParsed() = 0;
54 virtual void newRegionsParsed() = 0; 54 virtual void newRegionsParsed() = 0;
55 virtual void fileFailedToParse() = 0; 55 virtual void fileFailedToParse() = 0;
56 }; 56 };
57 57
58 class WebVTTParser { 58 class WebVTTParser {
59 public: 59 public:
60 virtual ~WebVTTParser() { }
61
62 enum ParseState { 60 enum ParseState {
63 Initial, 61 Initial,
64 Header, 62 Header,
65 Id, 63 Id,
66 TimingsAndSettings, 64 TimingsAndSettings,
67 CueText, 65 CueText,
68 BadCue 66 BadCue
69 }; 67 };
70 68
71 static PassOwnPtr<WebVTTParser> create(WebVTTParserClient* client, Document& document) 69 static PassOwnPtr<WebVTTParser> create(WebVTTParserClient* client, Document& document)
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 151
154 Vector<AtomicString> m_languageStack; 152 Vector<AtomicString> m_languageStack;
155 Vector<RefPtr<TextTrackCue> > m_cuelist; 153 Vector<RefPtr<TextTrackCue> > m_cuelist;
156 154
157 Vector<RefPtr<TextTrackRegion> > m_regionList; 155 Vector<RefPtr<TextTrackRegion> > m_regionList;
158 }; 156 };
159 157
160 } // namespace WebCore 158 } // namespace WebCore
161 159
162 #endif 160 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698