Issue 403193002: Fix the //sandbox/mac build when using a modern (10.7+) SDK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 403193002: Fix the //sandbox/mac build when using a modern (10.7+) SDK. (Closed)

Created:
6 years, 5 months ago by Robert Sesek

Modified:
6 years, 5 months ago

Reviewers:
Mark Mentovai, dmazzoni

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Fix the //sandbox/mac build when using a modern (10.7+) SDK. This doesn't use the dynamic library loader if the SDK has libxpc.dylib, and instead just relies on libSystem to load it. BUG=395364 R=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284427

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -40 lines)			Patch
M	sandbox/mac/BUILD.gn	View	1 chunk	+8 lines, -1 line	0 comments	Download
M	sandbox/mac/sandbox_mac.gypi	View	1 chunk	+44 lines, -36 lines	0 comments	Download
M	sandbox/mac/xpc.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	sandbox/mac/xpc.cc	View	2 chunks	+5 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

dmazzoni

I can confirm this fixes my local build too. Please land this change ASAP!

6 years, 5 months ago (2014-07-21 06:11:10 UTC) #3

Robert Sesek

On 2014/07/19 22:47:50, Mark Mentovai wrote: > Does the result actually launch on 10.6? Yes, ...

6 years, 5 months ago (2014-07-21 14:21:01 UTC) #4

Mark Mentovai

That’s what I thought, I just had to make sure. LGTM.

6 years, 5 months ago (2014-07-21 14:28:58 UTC) #5

Robert Sesek

6 years, 5 months ago (2014-07-21 14:36:37 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r284427 (presubmit successful).