Suppress ScriptForbiddenScope in Document.cpp and FrameView.cpp in release mode

Source/web/WebPluginContainerImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 666 matching lines @@
     // is cleanly detached. If an explicit detach doesn't happen, this
     // container is assumed to have died with the plugin element (and
     // its document), hence no unregistration step is needed.
     //
     m_element = 0;
 #else
     if (m_touchEventRequestType != TouchEventRequestTypeNone)
         m_element->document().didRemoveTouchEventHandler(m_element);
 #endif
 
+    ScriptForbiddenScope::SuppressScriptForbiddenScopeInRelease thisSuppressionShouldBeRemoved;

[haraken, 2014/07/19 03:39:49]

It's scary we're invoking JavaScript inside a destructor...

See a stack trace: https://code.google.com/p/chromium/issues/detail?id=395299

sof@: Probably is this problematic in oilpan? ~WebPluginContainerImpl() can
execute arbitrary JavaScript.

Either way I think we should land this CL sooner to fix outstanding release
block bugs.

[sof, 2014/07/19 06:14:43]

I can't access that one (Cc: me if you like, might help..), but I'm guessing
this happens when allowing scripting when calling PluginDestroyed on the plugin;
see
content/renderer/npapi/webplugin_impl.cc:WebPluginImpl::TearDownPluginInstance()
Calling into v8 during sweeping is definitely problematic. To quote ager when
this came earlier as a possible reason for a crash seen,

   "Entering V8 during sweeping (either weak processing or finalization) can
lead to nested GCs which we do not support."

+
     for (size_t i = 0; i < m_pluginLoadObservers.size(); ++i)
         m_pluginLoadObservers[i]->clearPluginContainer();
     m_webPlugin->destroy();
     if (m_webLayer)
         GraphicsLayer::unregisterContentsLayer(m_webLayer);
 }
 
 #if ENABLE(OILPAN)
 void WebPluginContainerImpl::detach()
 {
@@ skipping 242 matching lines @@
 
     return clipRect;
 }
 
 bool WebPluginContainerImpl::pluginShouldPersist() const
 {
     return m_webPlugin->shouldPersist();
 }
 
 } // namespace blink