|
|
Created:
6 years, 5 months ago by ehsan Modified:
6 years, 4 months ago CC:
chromium-reviews, erikwright+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
Descriptionbase: Include intrin.h to get _ReturnAddress from clang
This is similar to r228123, to fix another occurrence where
_ReturnAddress is declared manually.
BUG=395593
R=cpu@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288575
Patch Set 1 #Patch Set 2 : Added the bug number to the commit message. #
Messages
Total messages: 21 (0 generated)
On 2014/07/20 23:17:04, ehsan wrote: can you add the bug number? it can be the general 'make clang work on windows'
lgtm
Done, thanks for the review. How can I check this in?
Is this your first chromium change? http://www.chromium.org/developers/contributing-code
On 2014/07/24 20:43:29, cpu wrote: > Is this your first chromium change? > > http://www.chromium.org/developers/contributing-code No, I'm pretty sure I contributed something a few years ago, and signed the license agreement back then.
On 2014/07/24 21:20:17, ehsan wrote: > On 2014/07/24 20:43:29, cpu wrote: > > Is this your first chromium change? > > > > http://www.chromium.org/developers/contributing-code > > No, I'm pretty sure I contributed something a few years ago, and signed the > license agreement back then. That's https://codereview.chromium.org/7903008.
The CQ bit was checked by cpu@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ehsan.akhgari@gmail.com/403103006/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
Hmm, should I ask for another review?
it failed trybots, did you look at the failures?
On 2014/07/28 21:07:45, cpu wrote: > it failed trybots, did you look at the failures? Yes, it is complaining about the review rules, hence https://codereview.chromium.org/403103006/#msg13. :-)
needs owner from base I guess.
lgtm
The CQ bit was checked by cpu@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ehsan.akhgari@gmail.com/403103006/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
Message was sent while issue was closed.
Change committed as 288575 |