Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(751)

Issue 403103006: base: Include intrin.h to get _ReturnAddress from clang (Closed)

Created:
6 years, 5 months ago by ehsan
Modified:
6 years, 4 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

base: Include intrin.h to get _ReturnAddress from clang This is similar to r228123, to fix another occurrence where _ReturnAddress is declared manually. BUG=395593 R=cpu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288575

Patch Set 1 #

Patch Set 2 : Added the bug number to the commit message. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M base/location.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
ehsan
6 years, 5 months ago (2014-07-20 23:17:04 UTC) #1
cpu_(ooo_6.6-7.5)
On 2014/07/20 23:17:04, ehsan wrote: can you add the bug number? it can be the ...
6 years, 5 months ago (2014-07-21 00:57:24 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm
6 years, 5 months ago (2014-07-21 00:57:44 UTC) #3
ehsan
Done, thanks for the review. How can I check this in?
6 years, 5 months ago (2014-07-21 12:48:40 UTC) #4
cpu_(ooo_6.6-7.5)
Is this your first chromium change? http://www.chromium.org/developers/contributing-code
6 years, 5 months ago (2014-07-24 20:43:29 UTC) #5
ehsan
On 2014/07/24 20:43:29, cpu wrote: > Is this your first chromium change? > > http://www.chromium.org/developers/contributing-code ...
6 years, 5 months ago (2014-07-24 21:20:17 UTC) #6
ehsan
On 2014/07/24 21:20:17, ehsan wrote: > On 2014/07/24 20:43:29, cpu wrote: > > Is this ...
6 years, 5 months ago (2014-07-24 21:21:42 UTC) #7
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 5 months ago (2014-07-24 22:10:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ehsan.akhgari@gmail.com/403103006/20001
6 years, 5 months ago (2014-07-24 22:12:05 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 02:27:44 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 02:44:16 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/82275)
6 years, 5 months ago (2014-07-25 02:44:17 UTC) #12
ehsan
Hmm, should I ask for another review?
6 years, 5 months ago (2014-07-25 02:54:53 UTC) #13
cpu_(ooo_6.6-7.5)
it failed trybots, did you look at the failures?
6 years, 4 months ago (2014-07-28 21:07:45 UTC) #14
ehsan
On 2014/07/28 21:07:45, cpu wrote: > it failed trybots, did you look at the failures? ...
6 years, 4 months ago (2014-07-28 21:18:00 UTC) #15
cpu_(ooo_6.6-7.5)
needs owner from base I guess.
6 years, 4 months ago (2014-07-30 22:45:39 UTC) #16
brettw
lgtm
6 years, 4 months ago (2014-07-31 17:38:27 UTC) #17
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 4 months ago (2014-08-09 03:49:50 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ehsan.akhgari@gmail.com/403103006/20001
6 years, 4 months ago (2014-08-09 03:52:42 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-09 11:49:30 UTC) #20
commit-bot: I haz the power
6 years, 4 months ago (2014-08-09 14:48:43 UTC) #21
Message was sent while issue was closed.
Change committed as 288575

Powered by Google App Engine
This is Rietveld 408576698