Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 403103005: components: Add GN Build files for component_updater and user_manager. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, jochen (gone - plz use gerrit)
Project:
chromium
Visibility:
Public.

Description

components: Add GN Build files for component_updater and user_manager. BUG=None TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn component_updater user_manager R=brettw@chromium.org TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284560

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M components/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A components/component_updater/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
A components/user_manager/BUILD.gn View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
6 years, 5 months ago (2014-07-20 15:23:58 UTC) #1
brettw
lgtm
6 years, 5 months ago (2014-07-21 04:32:03 UTC) #2
tfarina
TBRing Jochen for components/
6 years, 5 months ago (2014-07-22 00:33:49 UTC) #3
tfarina
6 years, 5 months ago (2014-07-22 00:36:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r284560 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698