Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 403103003: Clean up OffTheRecordProfileImplTest unit test (Closed)

Created:
6 years, 5 months ago by James Cook
Modified:
6 years, 5 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Clean up OffTheRecordProfileImplTest unit test The previous version of this test could create up to 4 TestingProfiles: 1. TestingProfile from BrowserWithTestWindowTest::CreateProfile 2. TestingProfileWithHostZoomMap in the test body 3. An incognito version created by (2) via GetOffTheRecordProfile(). 4. An incognito version created in the test body Also the master/incognito relationships between these profiles are unclear. Reduce this to the 2 needed instances: 1. TestingProfileWithHostZoomMap owned by BrowserWithTestWindowTest 2. An incognito version in the test body BUG=395329 TEST=unit_tests OffTheRecordProfileImplTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284590

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -26 lines) Patch
M chrome/browser/profiles/off_the_record_profile_impl_unittest.cc View 8 chunks +24 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
James Cook
erg, PTAL.
6 years, 5 months ago (2014-07-19 03:32:06 UTC) #1
Elliot Glaysher
lgtm
6 years, 5 months ago (2014-07-21 21:07:22 UTC) #2
James Cook
The CQ bit was checked by jamescook@chromium.org
6 years, 5 months ago (2014-07-21 22:45:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/403103003/20001
6 years, 5 months ago (2014-07-21 22:47:52 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 02:05:27 UTC) #5
Message was sent while issue was closed.
Change committed as 284590

Powered by Google App Engine
This is Rietveld 408576698