Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 403103002: Prep for moving files into components/invalidation (Closed)

Created:
6 years, 5 months ago by rlarocque
Modified:
6 years, 5 months ago
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Prep for moving files into components/invalidation Refactors some dependencies to prepare for an upcoming move of invalidator code from sync/internal_api/public/base to components/invalidation. Highlights include: - Remove some sync/ dependencies on invalidator_state.h - Refactor P2PInvalidator to not require model_type.h - Remove ModelType dependencies from invalidator_util.h. Introduce sync/tools/invalidation_helper.h and chrome/browser/sync/glue/invalidation_helper.h to replace it. TBR=ben BUG=259559 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284822

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix compile issues #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -111 lines) Patch
A chrome/browser/sync/glue/invalidation_helper.h View 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/browser/sync/glue/invalidation_helper.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/fake_server_invalidation_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test/integration/p2p_invalidation_forwarder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M components/invalidation/p2p_invalidator_unittest.cc View 10 chunks +29 lines, -28 lines 0 comments Download
M sync/internal_api/public/base/invalidation_util.h View 4 chunks +0 lines, -18 lines 0 comments Download
M sync/internal_api/public/base/invalidation_util.cc View 3 chunks +0 lines, -58 lines 0 comments Download
M sync/internal_api/public/base/model_type.h View 1 chunk +3 lines, -2 lines 0 comments Download
M sync/internal_api/sync_manager_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/test/fake_sync_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M sync/tools/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A sync/tools/invalidation_helper.h View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A sync/tools/invalidation_helper.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M sync/tools/sync_client.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M sync/tools/sync_listen_notifications.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M sync/tools/sync_tools.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (0 generated)
rlarocque
The next patch will be ugly, so I decided to put as much of it ...
6 years, 5 months ago (2014-07-19 00:06:42 UTC) #1
pavely
lgtm
6 years, 5 months ago (2014-07-21 18:43:01 UTC) #2
Nicolas Zea
deps change LGTM
6 years, 5 months ago (2014-07-21 19:00:27 UTC) #3
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 5 months ago (2014-07-21 19:02:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/403103002/1
6 years, 5 months ago (2014-07-21 19:04:46 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 19:18:12 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 19:25:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/31145)
6 years, 5 months ago (2014-07-21 19:25:03 UTC) #8
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 5 months ago (2014-07-21 21:39:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/403103002/20001
6 years, 5 months ago (2014-07-21 21:47:37 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 22:51:26 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 22:55:35 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/81361)
6 years, 5 months ago (2014-07-21 22:55:36 UTC) #13
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 5 months ago (2014-07-21 23:02:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/403103002/40001
6 years, 5 months ago (2014-07-21 23:04:34 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 01:25:28 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 01:27:04 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/81393)
6 years, 5 months ago (2014-07-22 01:27:06 UTC) #18
rlarocque
I'm not sure why, but somehow the presubmit scripts don't think that zea@ is an ...
6 years, 5 months ago (2014-07-22 17:52:51 UTC) #19
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 5 months ago (2014-07-22 17:53:06 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/403103002/40001
6 years, 5 months ago (2014-07-22 17:54:27 UTC) #21
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 17:57:54 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 18:00:36 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/172535)
6 years, 5 months ago (2014-07-22 18:00:38 UTC) #24
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 5 months ago (2014-07-22 19:34:15 UTC) #25
rlarocque
The CQ bit was unchecked by rlarocque@chromium.org
6 years, 5 months ago (2014-07-22 19:34:15 UTC) #26
rlarocque
The CQ bit was checked by rlarocque@chromium.org
6 years, 5 months ago (2014-07-22 19:34:18 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/403103002/60001
6 years, 5 months ago (2014-07-22 19:35:16 UTC) #28
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-22 22:44:11 UTC) #29
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 00:19:14 UTC) #30
Message was sent while issue was closed.
Change committed as 284822

Powered by Google App Engine
This is Rietveld 408576698