Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 403063002: Roll libwebm 8be639:0d4cb4 (Closed)

Created:
6 years, 5 months ago by Tom Finegan
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Roll libwebm 8be639:0d4cb4 This roll: - Allows libwebm to build using clang-cl. - Allows removal of a workaround from libwebm's BUILD.gn. R=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284284

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Tom Finegan
PTAL/Thanks!
6 years, 5 months ago (2014-07-18 22:12:07 UTC) #1
Nico
lgtm This also allows removing a workaround from gn, it's not just for clang-cl.
6 years, 5 months ago (2014-07-18 22:16:35 UTC) #2
Tom Finegan
On 2014/07/18 22:16:35, Nico (away) wrote: > lgtm > > This also allows removing a ...
6 years, 5 months ago (2014-07-18 22:21:28 UTC) #3
Tom Finegan
The CQ bit was checked by tomfinegan@chromium.org
6 years, 5 months ago (2014-07-18 22:21:32 UTC) #4
Tom Finegan
The CQ bit was unchecked by tomfinegan@chromium.org
6 years, 5 months ago (2014-07-18 22:21:58 UTC) #5
Tom Finegan
The CQ bit was checked by tomfinegan@chromium.org
6 years, 5 months ago (2014-07-18 22:22:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tomfinegan@chromium.org/403063002/1
6 years, 5 months ago (2014-07-18 22:23:46 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 02:22:53 UTC) #8
Message was sent while issue was closed.
Change committed as 284284

Powered by Google App Engine
This is Rietveld 408576698