Extract RenderBox::invalidatePaintIfNeeded()

Extract RenderBox::invalidatePaintIfNeeded()

This reduces duplicated code for early returns in original
RenderBox::invalidateTreeIfNeeded(), and helps to ensure all code
needed to be executed for original and future early returns.

No functional change.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178687

[Xianzhu, 2014-07-21 16:49:01]

PTAL. This is the second of 4 patches split from
https://codereview.chromium.org/398343003/ (Unified invalidation path).

[dsinclair, 2014-07-21 17:10:57]

https://codereview.chromium.org/403033002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderBox.cpp (right):

https://codereview.chromium.org/403033002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderBox.cpp:1568: savePreviousBorderBoxSizeIfNeeded();
Just to verify, this is the ordering we want? It looks like previously we did
these two operations in both orders, so I'm assuming they don't have any affect
on each other.


if (doingFullRepaint()) {
  invalidateTreeIfNeeded()
  savePreviousBorderBoxSize()
  return
}

saveBorderBoxSizeIfNeeded();
invalidateTreeIfNeeded();

[Xianzhu, 2014-07-21 17:18:54]

https://codereview.chromium.org/403033002/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderBox.cpp (right):

https://codereview.chromium.org/403033002/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderBox.cpp:1568: savePreviousBorderBoxSizeIfNeeded();
On 2014/07/21 17:10:56, dsinclair wrote:
> Just to verify, this is the ordering we want? It looks like previously we did
> these two operations in both orders, so I'm assuming they don't have any
affect
> on each other.
> 
> 
> if (doingFullRepaint()) {
>   invalidateTreeIfNeeded()
>   savePreviousBorderBoxSize()
>   return
> }
> 
> saveBorderBoxSizeIfNeeded();
> invalidateTreeIfNeeded();

Yes.

saveBorderBoxSizeIfNeeded() is only required to be after invalidation of the box
itself, but doesn't matter whether it is before or after invalidation of
children.

[dsinclair, 2014-07-21 17:27:35]

lgtm

[Xianzhu, 2014-07-22 15:52:56]

Ping owners (leviw@, jchaffraix@)

[leviw_travelin_and_unemployed, 2014-07-22 18:21:04]

Okay. LGTM.

[Xianzhu, 2014-07-22 18:22:51]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-07-22 18:23:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/403033002/1

[commit-bot: I haz the power, 2014-07-22 19:28:44]

Change committed as 178687