Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 40303002: Simplify SharedWorkerRepository code (Chromium side) (Closed)

Created:
7 years, 2 months ago by kinuko
Modified:
7 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, michaeln, alecflett, Andrew T Wilson (Slow)
Visibility:
Public.

Description

Simplify SharedWorkerRepository code (Chromium side) - Move scattered worker repository code into one class (content::SharedWorkerRepository) - Use per-page client which implements RenderViewObserver - Implement RuntimeFeatures for shared workers - No more WebKit:: static method to initialize repository - Remove dead/unused code Blink side patch (landed): https://codereview.chromium.org/40143003/ BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231268

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -136 lines) Patch
M content/child/runtime_features.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 3 chunks +3 lines, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 4 chunks +0 lines, -7 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 3 chunks +0 lines, -18 lines 0 comments Download
A content/renderer/shared_worker_repository.h View 1 1 chunk +39 lines, -0 lines 0 comments Download
A content/renderer/shared_worker_repository.cc View 1 1 chunk +57 lines, -0 lines 0 comments Download
D content/renderer/websharedworkerrepository_impl.h View 1 chunk +0 lines, -37 lines 0 comments Download
D content/renderer/websharedworkerrepository_impl.cc View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
kinuko
Jochen, maybe you can review this one?
7 years, 2 months ago (2013-10-25 01:34:28 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/40303002/diff/1/content/renderer/shared_worker_repository.cc File content/renderer/shared_worker_repository.cc (right): https://codereview.chromium.org/40303002/diff/1/content/renderer/shared_worker_repository.cc#newcode38 content/renderer/shared_worker_repository.cc:38: if (url_mismatch) { no { } https://codereview.chromium.org/40303002/diff/1/content/renderer/shared_worker_repository.h File ...
7 years, 2 months ago (2013-10-25 11:33:29 UTC) #2
kinuko
Thx, updated. https://codereview.chromium.org/40303002/diff/1/content/renderer/shared_worker_repository.cc File content/renderer/shared_worker_repository.cc (right): https://codereview.chromium.org/40303002/diff/1/content/renderer/shared_worker_repository.cc#newcode38 content/renderer/shared_worker_repository.cc:38: if (url_mismatch) { On 2013/10/25 11:33:30, jochen ...
7 years, 1 month ago (2013-10-25 14:44:57 UTC) #3
kinuko
jam: can you do owner review for: content/child/runtime_features.cc content/content_renderer.gypi
7 years, 1 month ago (2013-10-25 14:46:28 UTC) #4
jam
lgtm
7 years, 1 month ago (2013-10-25 15:14:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/40303002/230001
7 years, 1 month ago (2013-10-27 08:56:47 UTC) #6
commit-bot: I haz the power
7 years, 1 month ago (2013-10-27 19:34:44 UTC) #7
Message was sent while issue was closed.
Change committed as 231268

Powered by Google App Engine
This is Rietveld 408576698