Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Unified Diff: chrome/app/chrome_main_uitest.cc

Issue 40301: Make SecondLaunch UI test not-flaky by using more reliable (Closed)
Patch Set: Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/chrome_main_uitest.cc
diff --git a/chrome/app/chrome_main_uitest.cc b/chrome/app/chrome_main_uitest.cc
index 6038c9ca58debd2eabe8abff01a6f47764e29924..b70e58c40ea8165f0914d53da9972d9577c98ee8 100644
--- a/chrome/app/chrome_main_uitest.cc
+++ b/chrome/app/chrome_main_uitest.cc
@@ -35,17 +35,13 @@ TEST_F(ChromeMainTest, AppTestingInterface) {
}
// Make sure that the second invocation creates a new window.
-// This test is disabled. See bug 5671.
-TEST_F(ChromeMainTest, DISABLED_SecondLaunch) {
+TEST_F(ChromeMainTest, SecondLaunch) {
include_testing_id_ = false;
use_existing_browser_ = true;
LaunchBrowser(CommandLine(L""), false);
- int window_count;
- ASSERT_TRUE(automation()->WaitForWindowCountToChange(1, &window_count,
- action_timeout_ms()));
- ASSERT_EQ(2, window_count);
+ ASSERT_TRUE(automation()->WaitForWindowCountToBecome(2, action_timeout_ms()));
}
TEST_F(ChromeMainTest, ReuseBrowserInstanceWhenOpeningFile) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698