Issue 403003002: SlotRef::GetValue INT32 case needs to be 64bit big endian aware

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 403003002: SlotRef::GetValue INT32 case needs to be 64bit big endian aware (Closed)

Created:
6 years, 5 months ago by andrew_low

Modified:
6 years, 5 months ago

Reviewers:
danno, Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

SlotRef::GetValue INT32 case needs to be 64bit big endian aware On 64bit big endian systems fetch the correct 32bits from the slot BUG=v8:3449 LOG=N R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22522

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	src/deoptimizer.cc	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Jakob Kummerow

LGTM with a nit. You'll need me to land this for you, right? https://codereview.chromium.org/403003002/diff/1/src/deoptimizer.cc File ...

6 years, 5 months ago (2014-07-19 11:44:36 UTC) #1

andrew_low

On 2014/07/19 11:44:36, Jakob wrote: > You'll need me to land this for you, right? ...

6 years, 5 months ago (2014-07-21 12:38:38 UTC) #2

Jakob Kummerow

6 years, 5 months ago (2014-07-22 11:35:55 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r22522 (presubmit successful).