Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 402993004: [Password Generation] Fix memory leak in test from r284169 (Closed)

Created:
6 years, 5 months ago by Garrett Casto
Modified:
6 years, 5 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org, groby-ooo-7-16
Project:
chromium
Visibility:
Public.

Description

[Password Generation] Fix memory leak in test from r284169 BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284307

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M components/password_manager/core/browser/password_manager_unittest.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Garrett Casto
6 years, 5 months ago (2014-07-18 20:50:43 UTC) #1
Ilya Sherman
LGTM
6 years, 5 months ago (2014-07-18 21:03:02 UTC) #2
Ilya Sherman
The CQ bit was checked by isherman@chromium.org
6 years, 5 months ago (2014-07-18 21:03:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gcasto@chromium.org/402993004/1
6 years, 5 months ago (2014-07-18 21:05:39 UTC) #4
Garrett Casto
The CQ bit was checked by gcasto@chromium.org
6 years, 5 months ago (2014-07-18 23:08:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gcasto@chromium.org/402993004/20001
6 years, 5 months ago (2014-07-18 23:09:53 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 04:42:01 UTC) #7
Message was sent while issue was closed.
Change committed as 284307

Powered by Google App Engine
This is Rietveld 408576698