Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 402983002: Remove -fsanitize=null for ubsan_vptr=1 build. (Closed)

Created:
6 years, 5 months ago by byoungyoung
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove -fsanitize=null for ubsan_vptr=1 build. As functional dependencies on -fsanitize=null are removed for -fsanitize=vptr (Clang r213393), removing the -fsanitize=null option accordingly. BUG=174801 R=aarya@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284245

Patch Set 1 #

Patch Set 2 : Resolved merge issue. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M build/common.gypi View 1 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
inferno
lgtm
6 years, 5 months ago (2014-07-18 18:41:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/byoungyoung@chromium.org/402983002/1
6 years, 5 months ago (2014-07-18 18:44:50 UTC) #2
byoungyoung
The CQ bit was checked by byoungyoung@chromium.org
6 years, 5 months ago (2014-07-18 19:26:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/byoungyoung@chromium.org/402983002/20001
6 years, 5 months ago (2014-07-18 19:27:44 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 23:09:36 UTC) #5
Message was sent while issue was closed.
Change committed as 284245

Powered by Google App Engine
This is Rietveld 408576698