Correctly translate Cellular Device properties to ONC

chromeos/network/onc/onc_signature.cc

Index: chromeos/network/onc/onc_signature.cc
diff --git a/chromeos/network/onc/onc_signature.cc b/chromeos/network/onc/onc_signature.cc
index 54632ac911b24385c082b7c539786b3deb602371..a0fea8ae58559cecf45d0f94f1ddc5d766015566 100644
--- a/chromeos/network/onc/onc_signature.cc
+++ b/chromeos/network/onc/onc_signature.cc
@@ -22,6 +22,9 @@ const OncValueSignature kStringSignature = {
 const OncValueSignature kIntegerSignature = {
   base::Value::TYPE_INTEGER, NULL
 };
+const OncValueSignature kDoubleSignature = {
+  base::Value::TYPE_DOUBLE, NULL
+};
 const OncValueSignature kStringListSignature = {
   base::Value::TYPE_LIST, NULL, &kStringSignature
 };
@@ -34,6 +37,9 @@ const OncValueSignature kIPConfigListSignature = {
 const OncValueSignature kCellularApnListSignature = {
   base::Value::TYPE_LIST, NULL, &kCellularApnSignature
 };
+const OncValueSignature kCellularFoundNetworkListSignature = {
+  base::Value::TYPE_LIST, NULL, &kCellularFoundNetworkSignature
+};
 
 const OncFieldSignature issuer_subject_pattern_fields[] = {
     { ::onc::client_cert::kCommonName, &kStringSignature},
@@ -217,9 +223,26 @@ const OncFieldSignature cellular_provider_fields[] = {
     {NULL}};
 
 const OncFieldSignature cellular_apn_fields[] = {
+    { ::onc::cellular_apn::kApn, &kStringSignature},
     { ::onc::cellular_apn::kName, &kStringSignature},
     { ::onc::cellular_apn::kUsername, &kStringSignature},
     { ::onc::cellular_apn::kPassword, &kStringSignature},
+    { ::onc::cellular_apn::kLocalizedName, &kStringSignature},
+    { ::onc::cellular_apn::kLanguage, &kStringSignature},
+    {NULL}};
+
+const OncFieldSignature cellular_found_network_fields[] = {
+    { ::onc::cellular_found_network::kStatus, &kStringSignature},
+    { ::onc::cellular_found_network::kNetworkId, &kStringSignature},
+    { ::onc::cellular_found_network::kShortName, &kStringSignature},
+    { ::onc::cellular_found_network::kLongName, &kStringSignature},
+    { ::onc::cellular_found_network::kTechnology, &kStringSignature},
+    {NULL}};
+
+const OncFieldSignature sim_lock_status_fields[] = {
+    { ::onc::sim_lock_status::kLockEnabled, &kBoolSignature},
+    { ::onc::sim_lock_status::kLockType, &kStringSignature},
+    { ::onc::sim_lock_status::kRetriesLeft, &kDoubleSignature},
     {NULL}};
 
 const OncFieldSignature cellular_fields[] = {
@@ -231,12 +254,19 @@ const OncFieldSignature cellular_fields[] = {
 const OncFieldSignature cellular_with_state_fields[] = {
     { ::onc::cellular::kActivateOverNonCellularNetwork, &kBoolSignature},
     { ::onc::cellular::kActivationState, &kStringSignature},
+    { ::onc::cellular::kNetworkTechnology, &kStringSignature},
+    { ::onc::cellular::kRoamingState, &kStringSignature},
+    { ::onc::cellular::kServingOperator, &kCellularProviderSignature},
+    {NULL}};
+
+const OncFieldSignature cellular_device_fields[] = {
     { ::onc::cellular::kAllowRoaming, &kBoolSignature},
+    { ::onc::cellular::kAPNList, &kCellularApnListSignature},

[pneubeck (no reviews), 2014/07/21 08:21:53]

this exists now in both CellularDevice and Cellular (and by 'inheritance' as
well in CellularWithState).
is one redundant?

[stevenjb, 2014/07/22 18:29:33]

I think it probably doesn't belong in Cellular, will remove.

     { ::onc::cellular::kCarrier, &kStringSignature},
     { ::onc::cellular::kESN, &kStringSignature},
     { ::onc::cellular::kFamily, &kStringSignature},
     { ::onc::cellular::kFirmwareRevision, &kStringSignature},
-    { ::onc::cellular::kFoundNetworks, &kStringSignature},
+    { ::onc::cellular::kFoundNetworks, &kCellularFoundNetworkListSignature},
     { ::onc::cellular::kHardwareRevision, &kStringSignature},
     { ::onc::cellular::kHomeProvider, &kCellularProviderSignature},
     { ::onc::cellular::kICCID, &kStringSignature},
@@ -247,18 +277,13 @@ const OncFieldSignature cellular_with_state_fields[] = {
     { ::onc::cellular::kMEID, &kStringSignature},
     { ::onc::cellular::kMIN, &kStringSignature},
     { ::onc::cellular::kModelID, &kStringSignature},
-    { ::onc::cellular::kNetworkTechnology, &kStringSignature},
-    { ::onc::cellular::kPRLVersion, &kStringSignature},
+    { ::onc::cellular::kPRLVersion, &kIntegerSignature},
     { ::onc::cellular::kProviderRequiresRoaming, &kBoolSignature},
-    { ::onc::cellular::kRoamingState, &kStringSignature},
     { ::onc::cellular::kSelectedNetwork, &kStringSignature},
-    { ::onc::cellular::kServingOperator, &kCellularProviderSignature},
-    { ::onc::cellular::kSIMLockEnabled, &kBoolSignature},
-    { ::onc::cellular::kSIMLockStatus, &kStringSignature},
-    { ::onc::cellular::kSIMLockType, &kStringSignature},
-    { ::onc::cellular::kSIMPresent, &kStringSignature},
-    { ::onc::cellular::kSupportedCarriers, &kStringSignature},
-    { ::onc::cellular::kSupportNetworkScan, &kStringSignature},
+    { ::onc::cellular::kSIMLockStatus, &kSIMLockStatusSignature},
+    { ::onc::cellular::kSIMPresent, &kBoolSignature},
+    { ::onc::cellular::kSupportedCarriers, &kStringListSignature},
+    { ::onc::cellular::kSupportNetworkScan, &kBoolSignature},
     {NULL}};
 
 const OncFieldSignature network_configuration_fields[] = {
@@ -403,12 +428,21 @@ const OncValueSignature kCellularWithStateSignature = {
   base::Value::TYPE_DICTIONARY, cellular_with_state_fields, NULL,
   &kCellularSignature
 };
+const OncValueSignature kCellularDeviceSignature = {
+  base::Value::TYPE_DICTIONARY, cellular_device_fields, NULL
+};
 const OncValueSignature kCellularProviderSignature = {
   base::Value::TYPE_DICTIONARY, cellular_provider_fields, NULL
 };
 const OncValueSignature kCellularApnSignature = {
   base::Value::TYPE_DICTIONARY, cellular_apn_fields, NULL
 };
+const OncValueSignature kCellularFoundNetworkSignature = {
+  base::Value::TYPE_DICTIONARY, cellular_found_network_fields, NULL
+};
+const OncValueSignature kSIMLockStatusSignature = {
+  base::Value::TYPE_DICTIONARY, sim_lock_status_fields, NULL
+};
 
 const OncFieldSignature* GetFieldSignature(const OncValueSignature& signature,
                                            const std::string& onc_field_name) {