Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 40293002: [SVG] Fix CSS transform handling when zoomed. (Closed)

Created:
7 years, 2 months ago by f(malita)
Modified:
7 years, 2 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, pdr, Stephen Chennney, f(malita)
Visibility:
Public.

Description

[SVG] Fix CSS transform handling when zoomed. CSS takes the page zoom factor into account for all computed length values, including transform translation components. OTOH, SVG applies the zoom factor globally (at the SVG root level) - so when using CSS transforms in SVG, the translation components are scaled twice. This CL adjusts CSS transforms when used in SVG to account for the unexpected translation scale. BUG=174910 R=pdr@chromium.org,schenney@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160546

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -0 lines) Patch
A LayoutTests/svg/zoom/page/zoom-css-transforms.svg View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/svg/zoom/page/zoom-css-transforms-expected.svg View 1 chunk +27 lines, -0 lines 0 comments Download
M Source/core/svg/SVGGraphicsElement.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
f(malita)
7 years, 2 months ago (2013-10-24 14:22:08 UTC) #1
pdr.
On 2013/10/24 14:22:08, Florin Malita wrote: LGTM.
7 years, 2 months ago (2013-10-25 03:28:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmalita@chromium.org/40293002/1
7 years, 2 months ago (2013-10-25 03:28:32 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-25 05:48:40 UTC) #4
Message was sent while issue was closed.
Change committed as 160546

Powered by Google App Engine
This is Rietveld 408576698