Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2055)

Unified Diff: Source/devtools/front_end/console/ConsoleView.js

Issue 402873002: DevTools: Build function details' raw location in DebuggerModel (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Comment addressed Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/console/ConsoleView.js
diff --git a/Source/devtools/front_end/console/ConsoleView.js b/Source/devtools/front_end/console/ConsoleView.js
index 61d4e8ea85b953165c9b919ee6a5a69e96316505..db9febc68b4a47e6aa15b068a157a7c93a875a72 100644
--- a/Source/devtools/front_end/console/ConsoleView.js
+++ b/Source/devtools/front_end/console/ConsoleView.js
@@ -805,26 +805,21 @@ WebInspector.ConsoleView.prototype = {
result.functionDetails(didGetDetails);
/**
- * @param {?DebuggerAgent.FunctionDetails} response
+ * @param {?WebInspector.DebuggerModel.FunctionDetails} response
*/
function didGetDetails(response)
{
- if (!response) {
+ if (!response || !response.location) {
addMessage();
return;
}
var url;
- var lineNumber;
- var columnNumber;
var script = target.debuggerModel.scriptForId(response.location.scriptId);
- if (script && script.sourceURL) {
+ if (script && script.sourceURL)
url = script.sourceURL;
- lineNumber = response.location.lineNumber + 1;
- columnNumber = response.location.columnNumber + 1;
- }
// FIXME: this should be using live location.
- addMessage(url, lineNumber, columnNumber);
+ addMessage(url, response.location.lineNumber, response.location.columnNumber);
}
},
« no previous file with comments | « Source/devtools/front_end/components/ObjectPropertiesSection.js ('k') | Source/devtools/front_end/main/Main.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698