Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1496)

Unified Diff: Source/devtools/front_end/components/ObjectPopoverHelper.js

Issue 402873002: DevTools: Build function details' raw location in DebuggerModel (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Comment addressed Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/components/ObjectPropertiesSection.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/components/ObjectPopoverHelper.js
diff --git a/Source/devtools/front_end/components/ObjectPopoverHelper.js b/Source/devtools/front_end/components/ObjectPopoverHelper.js
index ef13ce4d189ec78f4b8a345d412577e9fb9ab258..274229c35c0f3a7e5321f4536e655018d6a864c4 100644
--- a/Source/devtools/front_end/components/ObjectPopoverHelper.js
+++ b/Source/devtools/front_end/components/ObjectPopoverHelper.js
@@ -65,7 +65,7 @@ WebInspector.ObjectPopoverHelper.prototype = {
* @param {!WebInspector.Target} target
* @param {!Element} anchorElement
* @param {!Element} popoverContentElement
- * @param {?DebuggerAgent.FunctionDetails} response
+ * @param {?WebInspector.DebuggerModel.FunctionDetails} response
* @this {WebInspector.ObjectPopoverHelper}
*/
function didGetDetails(target, anchorElement, popoverContentElement, response)
@@ -80,9 +80,12 @@ WebInspector.ObjectPopoverHelper.prototype = {
var functionName = title.createChild("span", "function-name");
functionName.textContent = response.functionName || WebInspector.UIString("(anonymous function)");
- this._linkifier = new WebInspector.Linkifier();
- var rawLocation = WebInspector.DebuggerModel.Location.fromPayload(target, response.location);
- var link = this._linkifier.linkifyRawLocation(rawLocation, "function-location-link");
+ var rawLocation = response.location;
+ var link;
+ if (rawLocation) {
+ this._linkifier = new WebInspector.Linkifier();
+ link = this._linkifier.linkifyRawLocation(rawLocation, "function-location-link");
+ }
if (link)
title.appendChild(link);
« no previous file with comments | « no previous file | Source/devtools/front_end/components/ObjectPropertiesSection.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698