Issue 402873002: DevTools: Build function details' raw location in DebuggerModel

Issue 402873002: DevTools: Build function details' raw location in DebuggerModel (Closed)

Created:
6 years, 5 months ago by apavlov

Modified:
6 years, 5 months ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Build function details' raw location in DebuggerModel Previously, it was the clients' responsibility to build raw locations based on DebuggerAgent.Location. R=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178457

Patch Set 1 #

Patch Set 2 : Clean up unused vars #

Total comments: 1

Patch Set 3 : Comment addressed #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -36 lines)			Patch
M	Source/devtools/front_end/components/ObjectPopoverHelper.js	View		2 chunks	+7 lines, -4 lines	0 comments	Download
M	Source/devtools/front_end/components/ObjectPropertiesSection.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/console/ConsoleView.js	View	1	1 chunk	+4 lines, -9 lines	0 comments	Download
M	Source/devtools/front_end/main/Main.js	View	1 2	1 chunk	+3 lines, -7 lines	0 comments	Download
M	Source/devtools/front_end/sdk/DebuggerModel.js	View		4 chunks	+11 lines, -4 lines	0 comments	Download
M	Source/devtools/front_end/sdk/RemoteObject.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/sources/SourcesPanel.js	View		1 chunk	+6 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

vsevik

lgtm https://chromiumcodereview.appspot.com/402873002/diff/20001/Source/devtools/front_end/main/Main.js File Source/devtools/front_end/main/Main.js (right): https://chromiumcodereview.appspot.com/402873002/diff/20001/Source/devtools/front_end/main/Main.js#newcode602 Source/devtools/front_end/main/Main.js:602: if (!response) Should we do if (!response || ...

6 years, 5 months ago (2014-07-18 15:00:46 UTC) #2

apavlov

On 2014/07/18 15:00:46, vsevik wrote: > lgtm > > https://chromiumcodereview.appspot.com/402873002/diff/20001/Source/devtools/front_end/main/Main.js > File Source/devtools/front_end/main/Main.js (right): > ...

6 years, 5 months ago (2014-07-18 15:09:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/402873002/40001

6 years, 5 months ago (2014-07-18 15:10:03 UTC) #5

Message was sent while issue was closed.

Change committed as 178457

Expand Messages | Collapse Messages