Issue 402773003: Remove things from breakpad_tools.gypi that are set by build/common.gypi or implicitly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 402773003: Remove things from breakpad_tools.gypi that are set by build/common.gypi or implicitly. (Closed)

Created:
6 years, 5 months ago by Nico

Modified:
6 years, 5 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Remove things from breakpad_tools.gypi that are set by build/common.gypi or implicitly. No intended behavior change. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283959

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -19 lines)			Patch
	M	breakpad/breakpad_tools.gypi	View		1 chunk	+0 lines, -19 lines	0 comments	Download

Total messages: 5 (0 generated)

Nico

Here's the cleanup I promised long ago in https://codereview.chromium.org/379923008/

6 years, 5 months ago (2014-07-17 22:44:01 UTC) #1

Lei Zhang

On 2014/07/17 22:44:01, Nico (away) wrote: > Here's the cleanup I promised long ago in ...

6 years, 5 months ago (2014-07-17 22:47:15 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/402773003/1

6 years, 5 months ago (2014-07-17 22:54:11 UTC) #4

Message was sent while issue was closed.

Change committed as 283959