Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 402753002: mac: [Yosemite] Remove unnecessary AppKit private method swizzling. (Closed)

Created:
6 years, 5 months ago by erikchen
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mac: [Yosemite] Remove unnecessary AppKit private method swizzling. In Yosemite, the fullscreen button replaces the zoom button. We no longer need to swizzle the method that returns the origin of the fullscreen button. BUG=388772 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284021

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M chrome/browser/ui/cocoa/custom_frame_view.mm View 1 chunk +20 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
erikchen
shess: Please review.
6 years, 5 months ago (2014-07-17 21:24:30 UTC) #1
Scott Hess - ex-Googler
lgtm
6 years, 5 months ago (2014-07-17 21:41:16 UTC) #2
erikchen
The CQ bit was checked by erikchen@chromium.org
6 years, 5 months ago (2014-07-17 21:42:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/402753002/40001
6 years, 5 months ago (2014-07-17 21:43:53 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 02:20:44 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 07:11:33 UTC) #6
Message was sent while issue was closed.
Change committed as 284021

Powered by Google App Engine
This is Rietveld 408576698